Fix #88: Mark as bad any run with >=66 missing results #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a high enough threshold that it doesn't exclude runs with missing results (e.g., due to -print or -crash being unsupported), but does catch the vast majority with an unusually high number of missing results.
|
https://gist.github.com/gsnedders/676cd70e21bcd8d96a79550582d455b3 for a diff of the output. |
|
Oh, actually, maybe my data is bad here; seems to omit cases where entire trees are missing. |
|
@gsnedders what are some of the runs that you're hoping this will exclude? Any idea what went wrong with them? I would quite like it if we used the manifest when processing results in wpt.fyi, so that we could tell if a run is complete or not and label incomplete runs, or at least know for sure how many tests of which type are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a high enough threshold that it doesn't exclude runs with missing results (e.g., due to -print or -crash being unsupported), but does catch the vast majority with an unusually high number of missing
results.