Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Baseline status definition review date text #479

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Dec 5, 2023

This PR moves the "due for review" date to the "Ownership and maintenance" section of the Baseline doc.

As @tidoust noted in #423 (comment), the existing phrasing is somewhat over determined. It suggests that the duration and only the duration would come up for review. This conflicts with the governance text that says that reviewing and revising the definition (in general) is on the agenda annually. This PR attempts to reconcile the competing texts.

@ddbeck
Copy link
Collaborator Author

ddbeck commented Dec 5, 2023

(Since this touches the Baseline definition, it needs review from the owners group.)

@atopal
Copy link
Collaborator

atopal commented Dec 5, 2023

LGTM!

@@ -118,6 +118,8 @@ This is but one of several possible stories to help keep in mind the needs and c
The WebDX community group, through the [web-platform-dx/web-features-set owners group](../GOVERNANCE.md), maintains this document.
Based on WebDX community group research, the web-features owners group decides matters such as the core browser set, releases, editorial overrides, and so on.

The status definition is due for review by the governance group on 7 November 2024.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section and governance document use "owners group", not "governance group".

Also, it suddenly occurs to me that putting an explicit due date in the definition itself means the definition will have to be updated every year no matter what, even if the governance group determines that no updates are warranted. Is that intended? And does the date actually matter?

Suggested change
The status definition is due for review by the governance group on 7 November 2024.
The owners group reviews the status definition at least once per calendar year.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the suggestion was to obligate an at-least annual review, to keep the advocates for the time-based proxy on usage honest (i.e., to ensure that the 30 months didn't unintentionally lead to lower or higher likely usage figures). But it was @LeoMcA suggestion, so maybe he can express the intent better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, I'm not advocating for a change of intent. I'm merely pointing out that hardcoding a date in the definition itself de facto means that the definition has to be updated every year, to replace the due with next year's due date.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that's a correct reading. I think that was even the intended reading. So I don't want to change to your proposed text unless it would also satisfy the original intent. 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed #502 about "governance group" vs. "owners groups".

Beyond that this PR is just moving the date. I think it's fine to have the date in this document and being required to update it once a year. Not a big burden for the owners I think :)

@foolip foolip merged commit 2c57db4 into web-platform-dx:main Dec 18, 2023
2 checks passed
@ddbeck ddbeck deleted the 2023-12-05-move-review-schedule branch March 27, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants