Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Baseline schema for new definition of Baseline (and refresh some statuses) #434

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Update Baseline schema for new definition of Baseline (and refresh some statuses) #434

merged 14 commits into from
Nov 30, 2023

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Nov 27, 2023 •
edited
Loading

This PR updates the schema and some status information to correspond to #423.

This PR updates only those features where:

  • The feature already has a Baseline status (including those originally commented out) and
  • Updating the status required no changes to the underlying feature list (e.g., a few have invalid feature IDs)

Baseline status calculation details

border-image
Key Baseline Since Versions
border-image ✅ 2017-02-01 Chrome 56
Chrome Android 56 🔑💎
Edge 12
Firefox 50
Firefox for Android 50
Safari 9.1
Safari on iOS 9.3
css.properties.border-image ✅ 2015-07-28 Chrome 16
Chrome Android 18
Edge 12 🔑💎
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 6
css.properties.border-image.fill ✅ 2015-07-28 Chrome 16
Chrome Android 18
Edge 12 🔑💎
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 6
css.properties.border-image.gradient ✅ 2015-07-28 Chrome 7
Chrome Android 18
Edge 12 🔑💎
Firefox 29
Firefox for Android 29
Safari 4
Safari on iOS 3.2
css.properties.border-image.optional_border_image_slice ✅ 2015-07-28 Chrome 16
Chrome Android 18
Edge 12 🔑💎
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 6
css.properties.border-image-outset ✅ 2015-07-28 Chrome 15
Chrome Android 18
Edge 12 🔑💎
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 6
css.properties.border-image-repeat ✅ 2016-03-21 Chrome 15
Chrome Android 18
Edge 12
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 9.3 🔑💎
css.properties.border-image-repeat.round ✅ 2016-03-21 Chrome 30
Chrome Android 30
Edge 12
Firefox 15
Firefox for Android 15
Safari 9.1 🔑💎
Safari on iOS 9.3
css.properties.border-image-repeat.space ✅ 2017-02-01 Chrome 56
Chrome Android 56 🔑💎
Edge 12
Firefox 50
Firefox for Android 50
Safari 9.1
Safari on iOS 9.3
css.properties.border-image-slice ✅ 2015-07-28 Chrome 15
Chrome Android 18
Edge 12 🔑💎
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 6
css.properties.border-image-source ✅ 2015-07-28 Chrome 15
Chrome Android 18
Edge 12 🔑💎
Firefox 15
Firefox for Android 15
Safari 6
Safari on iOS 6
css.properties.border-image-width ✅ 2015-07-28 Chrome 15
Chrome Android 18
Edge 12 🔑💎
Firefox 13
Firefox for Android 14
Safari 6
Safari on iOS 6
canvas-context-lost
Key Baseline Since Versions
canvas-context-lost ❌ Chrome 99
Chrome Android 99
Edge 99
Firefox ❌
Firefox for Android ❌
Safari ❌
Safari on iOS ❌
api.CanvasRenderingContext2D.isContextLost ❌ Chrome 99
Chrome Android 99
Edge 99
Firefox ❌
Firefox for Android ❌
Safari ❌
Safari on iOS ❌
api.HTMLCanvasElement.contextlost_event ❌ Chrome 98
Chrome Android 98
Edge 98
Firefox ❌
Firefox for Android ❌
Safari ❌
Safari on iOS ❌
api.HTMLCanvasElement.contextrestored_event ❌ Chrome 98
Chrome Android 98
Edge 98
Firefox ❌
Firefox for Android ❌
Safari ❌
Safari on iOS ❌
api.OffscreenCanvas.contextlost_event ❌ Chrome 99
Chrome Android 99
Edge 99
Firefox 105
Firefox for Android 105
Safari ❌
Safari on iOS ❌
api.OffscreenCanvas.contextrestored_event ❌ Chrome 99
Chrome Android 99
Edge 99
Firefox 105
Firefox for Android 105
Safari ❌
Safari on iOS ❌
api.OffscreenCanvasRenderingContext2D.isContextLost ❌ Chrome 99
Chrome Android 99
Edge 99
Firefox ❌
Firefox for Android ❌
Safari ❌
Safari on iOS ❌
cascade-layers
Key Baseline Since Versions
cascade-layers 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
css.at-rules.layer 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
css.at-rules.import.layer 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
api.CSSImportRule.layerName 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
api.CSSLayerBlockRule 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
api.CSSLayerBlockRule.name 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
api.CSSLayerStatementRule 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
api.CSSLayerStatementRule.nameList 🔵 2022-03-15 Chrome 99
Chrome Android 99
Edge 99
Firefox 97
Firefox for Android 97
Safari 15.4 🔑💎
Safari on iOS 15.4
container-queries
Key Baseline Since Versions
container-queries 🔵 2023-02-14 Chrome 105
Chrome Android 105
Edge 105
Firefox 110 🔑💎
Firefox for Android 110
Safari 16
Safari on iOS 16
css.at-rules.container 🔵 2023-02-14 Chrome 105
Chrome Android 105
Edge 105
Firefox 110 🔑💎
Firefox for Android 110
Safari 16
Safari on iOS 16
css.properties.contain 🔵 2022-03-15 Chrome 52
Chrome Android 52
Edge 79
Firefox 69
Firefox for Android 79
Safari 15.4 🔑💎
Safari on iOS 15.4
css.properties.contain.inline-size 🔵 2022-09-02 Chrome 105 🔑💎
Chrome Android 105
Edge 105
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
css.properties.contain.style 🔵 2022-07-26 Chrome 52
Chrome Android 52
Edge 79
Firefox 103 🔑💎
Firefox for Android 103
Safari 15.4
Safari on iOS 15.4
css.properties.container 🔵 2023-02-14 Chrome 105
Chrome Android 105
Edge 105
Firefox 110 🔑💎
Firefox for Android 110
Safari 16
Safari on iOS 16
css.properties.container-name 🔵 2023-02-14 Chrome 105
Chrome Android 105
Edge 105
Firefox 110 🔑💎
Firefox for Android 110
Safari 16
Safari on iOS 16
css.properties.container-type 🔵 2023-02-14 Chrome 105
Chrome Android 105
Edge 105
Firefox 110 🔑💎
Firefox for Android 110
Safari 16
Safari on iOS 16
grid-animation
Key Baseline Since Versions
grid-animation 🔵 2022-10-27 Chrome 107
Chrome Android 107
Edge 107 🔑💎
Firefox 66
Firefox for Android 66
Safari 16
Safari on iOS 16
css.properties.grid-template-columns.animation 🔵 2022-10-27 Chrome 107
Chrome Android 107
Edge 107 🔑💎
Firefox 66
Firefox for Android 66
Safari 16
Safari on iOS 16
css.properties.grid-template-rows.animation 🔵 2022-10-27 Chrome 107
Chrome Android 107
Edge 107 🔑💎
Firefox 66
Firefox for Android 66
Safari 16
Safari on iOS 16
viewport-relative-unit-variants
Key Baseline Since Versions
viewport-relative-unit-variants 🔵 2022-12-06 Chrome 108
Chrome Android 108
Edge 108 🔑💎
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
css.types.length.vb 🔵 2022-12-06 Chrome 108
Chrome Android 108
Edge 108 🔑💎
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
css.types.length.vi 🔵 2022-12-06 Chrome 108
Chrome Android 108
Edge 108 🔑💎
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
css.types.length.viewport_percentage_units_dynamic 🔵 2022-12-06 Chrome 108
Chrome Android 108
Edge 108 🔑💎
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
css.types.length.viewport_percentage_units_large 🔵 2022-12-06 Chrome 108
Chrome Android 108
Edge 108 🔑💎
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
css.types.length.viewport_percentage_units_small 🔵 2022-12-06 Chrome 108
Chrome Android 108
Edge 108 🔑💎
Firefox 101
Firefox for Android 101
Safari 15.4
Safari on iOS 15.4
viewport-relative-units
Key Baseline Since Versions
viewport-relative-units ✅ 2017-10-17 Chrome 26
Chrome Android 26
Edge 16 🔑💎
Firefox 19
Firefox for Android 19
Safari 7
Safari on iOS 7
css.types.length.vh ✅ 2015-07-28 Chrome 20
Chrome Android 25
Edge 12 🔑💎
Firefox 19
Firefox for Android 19
Safari 6
Safari on iOS 6
css.types.length.vmax ✅ 2017-10-17 Chrome 26
Chrome Android 26
Edge 16 🔑💎
Firefox 19
Firefox for Android 19
Safari 7
Safari on iOS 7
css.types.length.vmin ✅ 2015-07-28 Chrome 26
Chrome Android 26
Edge 12 🔑💎
Firefox 19
Firefox for Android 19
Safari 7
Safari on iOS 7
css.types.length.vw ✅ 2015-07-28 Chrome 20
Chrome Android 25
Edge 12 🔑💎
Firefox 19
Firefox for Android 19
Safari 6
Safari on iOS 6

@ddbeck ddbeck marked this pull request as ready for review November 28, 2023 10:03
@ddbeck ddbeck requested a review from foolip November 28, 2023 10:03
foolip
foolip reviewed Nov 28, 2023
View reviewed changes
index.ts Outdated Show resolved Hide resolved
index.ts Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ddbeck ddbeck requested review from foolip and LeoMcA November 29, 2023 10:54
LeoMcA
LeoMcA reviewed Nov 29, 2023
View reviewed changes
feature-group-definitions/subgrid.yml Outdated
@@ -2,13 +2,14 @@ spec: https://drafts.csswg.org/css-grid-2/#subgrids
caniuse: css-subgrid
usage_stats: https://chromestatus.com/metrics/feature/timeline/popularity/4680
status:
is_baseline: true
since: "2023-09-15" # since Edge 117
baseline: false
Copy link
Collaborator

@LeoMcA LeoMcA Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be baseline low? (Is it not because we're missing a firefox_android key below?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is "correct" because BCD says that the css.properties.grid-template-rows.subgrid feature is unsupported on Firefox for Android. This is "wrong" because the data is likely to be wrong (BCD says css.properties.grid-template-columns.subgrid is supported on Firefox for Android).

Which is to say, the Baseline status is wrong for the right reason.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see mdn/browser-compat-data#21388 should fix this - nice 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I've pushed a change to accept the latest value now. 👍

@ddbeck ddbeck mentioned this pull request Nov 29, 2023
Closed
LeoMcA
LeoMcA approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more schema comments (in terms of backwards compatibility) but otherwise lgtm

feature-group-definitions/canvas-context-lost.yml Outdated Show resolved Hide resolved
feature-group-definitions/subgrid.yml Outdated
@@ -2,13 +2,14 @@ spec: https://drafts.csswg.org/css-grid-2/#subgrids
caniuse: css-subgrid
usage_stats: https://chromestatus.com/metrics/feature/timeline/popularity/4680
status:
is_baseline: true
since: "2023-09-15" # since Edge 117
baseline: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see mdn/browser-compat-data#21388 should fix this - nice 👍

index.ts
Comment on lines +30 to +31
/** Whether the feature is Baseline (legacy) */
is_baseline?: true | false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed from the schema? Or are we keeping it for backwards compatibility? (No need to do so for MDN)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remove all of the old statuses yet—they need actual reviews for the feature lists. I'll do that in a follow up PR.

index.ts
baseline?: BaselineHighLow | false;
/** Whether the feature is Baseline (legacy) */
is_baseline?: true | false;
/** Date the feature achieved Baseline status (legacy) */
since?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly - no need to keep this in the schema, if MDN as consumer is the reason for it.

@ddbeck ddbeck merged commit 09953bc into web-platform-dx:main Nov 30, 2023
2 checks passed
@ddbeck ddbeck deleted the 2023-11-27-new-baseline-schema branch November 30, 2023 10:22
@ddbeck ddbeck mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddbeck @foolip @LeoMcA