Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Baseline definition document #423
Add Baseline definition document #423
Changes from 3 commits
2c78cb8
ed538bb
18cd60e
34e4c0b
7fd5f49
14b1c5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the list is not meant to be exhaustive, but I'm thinking it would still be useful to mention WebViews explicitly here - or perhaps in the Future Considerations section?. WebViews are also a widely used non-web web setting (and the term should speak to developers even though it remains ill-defined...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is a good thought though I don't know exactly where it sits either. I think it's more of a future consideration than a non-goal, but it's possible it could become a non-goal. I filed #477 to take up this question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be reading too much into this, but that seems to suggest that the revision is scoped to re-evaluating the duration, and only the duration, whereas my understanding is that the governance group will review the whole definition.
Alternatively, the ownership and maintenance section could perhaps make explicit the "revision at least once per year" policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is probably worth moving or revising. That said, this was one of the late additions to the Baseline definition text. I'm not comfortable approving this unilaterally. I'd like to merge the text as is, then propose the narrower change here as a separate PR for the owners group to consider in isolation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not filing issues for these, leaving them here seems fine to me.