Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split text-underline-offset from text-underline-position #2652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions features/text-underline-offset.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: text-underline-offset
description: "The `text-underline-offset` CSS property shifts underlines on text from the initial position by a given distance. The initial position is affected by the `text-underline-position` property."
spec: https://drafts.csswg.org/css-text-decor-4/#underline-offset
group: text
status:
compute_from: css.properties.text-underline-offset
compat_features:
- css.properties.text-underline-offset
- css.properties.text-underline-offset.auto
- css.properties.text-underline-offset.percentage
42 changes: 42 additions & 0 deletions features/text-underline-offset.yml.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Generated from: text-underline-offset.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: high
baseline_low_date: 2020-11-19
baseline_high_date: 2023-05-19
support:
chrome: "87"
chrome_android: "87"
edge: "87"
firefox: "70"
firefox_android: "79"
safari: "12.1"
safari_ios: "12.2"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: high
# baseline_low_date: 2020-11-19
# baseline_high_date: 2023-05-19
# support:
# chrome: "87"
# chrome_android: "87"
# edge: "87"
# firefox: "70"
# firefox_android: "79"
# safari: "12.1"
# safari_ios: "12.2"
- css.properties.text-underline-offset
- css.properties.text-underline-offset.auto

# baseline: low
# baseline_low_date: 2024-12-11
# support:
# chrome: "87"
# chrome_android: "87"
# edge: "87"
# firefox: "74"
# firefox_android: "79"
# safari: "18.2"
# safari_ios: "18.2"
- css.properties.text-underline-offset.percentage
11 changes: 4 additions & 7 deletions features/text-underline-position.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
name: Text underline position
description: "The `text-underline-position` and `text-underline-offset` CSS properties set the position and distance from initial position of text underlines on text with `text-decoration: underline`."
spec: https://drafts.csswg.org/css-text-decor-4/#line-decoration
name: text-underline-position
description: "The `text-underline-position` CSS property set the position of underlines text. For example, `text-underline-position: under` places the underline below the text, avoiding crossing descenders. The underline may be further adjusted by the `text-underline-offset` property."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "The `text-underline-position` CSS property set the position of underlines text. For example, `text-underline-position: under` places the underline below the text, avoiding crossing descenders. The underline may be further adjusted by the `text-underline-offset` property."
description: "The `text-underline-position` CSS property sets the position of underlines on text. For example, `text-underline-position: under` places the underline below the text, avoiding crossing descenders. The underline may be further adjusted by the `text-underline-offset` property."

spec: https://drafts.csswg.org/css-text-decor-4/#text-underline-position-property
group: text
status:
compute_from: css.properties.text-underline-offset
compute_from: css.properties.text-underline-position
compat_features:
- css.properties.text-underline-offset
- css.properties.text-underline-offset.auto
- css.properties.text-underline-offset.percentage
- css.properties.text-underline-position
- css.properties.text-underline-position.from-font
- css.properties.text-underline-position.left
Expand Down
40 changes: 7 additions & 33 deletions features/text-underline-position.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,18 @@

status:
baseline: high
baseline_low_date: 2020-11-19
baseline_high_date: 2023-05-19
baseline_low_date: 2020-07-28
baseline_high_date: 2023-01-28
support:
chrome: "87"
chrome_android: "87"
edge: "87"
firefox: "70"
chrome: "33"
chrome_android: "33"
edge: "12"
firefox: "74"
firefox_android: "79"
safari: "12.1"
safari_ios: "12.2"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: high
# baseline_low_date: 2020-07-28
# baseline_high_date: 2023-01-28
Expand All @@ -40,21 +41,6 @@ compat_features:
# safari_ios: "12.2"
- css.properties.text-underline-position.under

# ⬇️ Same status as overall feature ⬇️
# baseline: high
# baseline_low_date: 2020-11-19
# baseline_high_date: 2023-05-19
# support:
# chrome: "87"
# chrome_android: "87"
# edge: "87"
# firefox: "70"
# firefox_android: "79"
# safari: "12.1"
# safari_ios: "12.2"
- css.properties.text-underline-offset
- css.properties.text-underline-offset.auto

# baseline: high
# baseline_low_date: 2020-11-19
# baseline_high_date: 2023-05-19
Expand All @@ -80,15 +66,3 @@ compat_features:
# safari_ios: "18.2"
- css.properties.text-underline-position.left
- css.properties.text-underline-position.right

# baseline: low
# baseline_low_date: 2024-12-11
# support:
# chrome: "87"
# chrome_android: "87"
# edge: "87"
# firefox: "74"
# firefox_android: "79"
# safari: "18.2"
# safari_ios: "18.2"
- css.properties.text-underline-offset.percentage