Remove redundant compat_features keys from features with comments #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
reviewed
Jan 14, 2025
There was a problem hiding this comment.
OK, this looks good. Some minor edits suggested here, but optional.
This PR has been open for some time, so the last step here is to merge main into this branch and refresh the dist.
Thank you, @queengooborg.
Co-authored-by: Daniel D. Beck <[email protected]>
@queengooborg can you do that, please? |
Elchi3
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant
compat_featureskeys from web features that have comments around them. This is an important manual step required to pave the way towards automated removal ofcompat_featureskeys.Note: some wording in the comments was updated to maintain context without the presence of the
compat_featuresvalue.