Skip to content

Commit

Permalink
Remove redundant compat_features keys from features with comments (#2345
Browse files Browse the repository at this point in the history
)

* Remove redundant compat_features keys from features with comments

* Apply suggestions from code review

Co-authored-by: Daniel D. Beck <[email protected]>

---------

Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
  • Loading branch information
3 people authored Jan 21, 2025
1 parent fa28e44 commit 3d8b4ff
Show file tree
Hide file tree
Showing 16 changed files with 18 additions and 80 deletions.
2 changes: 0 additions & 2 deletions features/article.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/sections.html#the-article-element
group: html-elements
# Note: <article> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.article
2 changes: 0 additions & 2 deletions features/aside.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/sections.html#the-aside-element
group: html-elements
# Note: <aside> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.aside
13 changes: 1 addition & 12 deletions features/audio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,5 @@ group:
caniuse: audio
status:
compute_from: html.elements.audio
# TODO: Include relevant parts of HTMLMediaElement when possible:
# TODO: Tag relevant parts of HTMLMediaElement when possible:
# https://github.com/web-platform-dx/web-features/issues/1173
compat_features:
- api.HTMLAudioElement
- api.HTMLAudioElement.Audio
- html.elements.audio
- html.elements.audio.autoplay
- html.elements.audio.controls
- html.elements.audio.crossorigin
- html.elements.audio.loop
- html.elements.audio.muted
- html.elements.audio.preload
- html.elements.audio.src
3 changes: 0 additions & 3 deletions features/figure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,3 @@ spec:
group: html-elements
# Note: <figure> and <figcaption> are part of https://caniuse.com/html5semantic
# but that covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.figcaption
- html.elements.figure
5 changes: 0 additions & 5 deletions features/font-variant-position.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,3 @@ group: font-features
# References:
# - https://issues.chromium.org/issues/352218916
# - https://bugs.webkit.org/show_bug.cgi?id=151471
compat_features:
- css.properties.font-variant-position
- css.properties.font-variant-position.normal
- css.properties.font-variant-position.sub
- css.properties.font-variant-position.super
3 changes: 0 additions & 3 deletions features/header-footer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,3 @@ spec:
group: html-elements
# Note: <header> and <footer> are part of https://caniuse.com/html5semantic but
# that feature covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.footer
- html.elements.header
7 changes: 1 addition & 6 deletions features/hsl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ caniuse: css3-colors
group: color-types
status:
compute_from: css.types.color.hsl.alpha_parameter
# TODO: For alignment with caniuse, add `hsla()` features when https://github.com/mdn/browser-compat-data/issues/24191 is resolved and update compute_from
compat_features:
- css.types.color.hsl
- css.types.color.hsl.alpha_parameter
- css.types.color.hsl.mixed_type_parameters
- css.types.color.hsl.space_separated_parameters
# TODO: For alignment with caniuse, tag `hsla()` features when https://github.com/mdn/browser-compat-data/issues/24191 is resolved and update compute_from
15 changes: 6 additions & 9 deletions features/ins.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@ name: <ins>
description: The `<ins>` element element represents a range of text that has been inserted into a document, styling text as underlined by default.
spec: https://html.spec.whatwg.org/multipage/edits.html#the-ins-element
group: html-elements
compat_features:
# TODO - Removed until #1173 is resolved, these APIs are currently listed
# in <del> to prevent the error.
# - api.HTMLModElement
# - api.HTMLModElement.cite
# - api.HTMLModElement.dateTime
- html.elements.ins
- html.elements.ins.cite
- html.elements.ins.datetime
# TODO - Removed until #1173 is resolved, these APIs are currently listed
# in <del> to prevent the error.
# compat_features:
# - api.HTMLModElement
# - api.HTMLModElement.cite
# - api.HTMLModElement.dateTime
6 changes: 1 addition & 5 deletions features/json-modules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,4 @@ name: JSON import attributes
description: 'Module `import … with { type: "json" }` statements load JSON data. Also known as JSON module scripts and formerly known as import assertions.'
spec: https://html.spec.whatwg.org/multipage/webappapis.html#json-module-script
group: json
compat_features:
# TODO: Include when https://github.com/web-platform-dx/web-features/issues/1173
# is resolved.
# - javascript.statements.import
- javascript.statements.import.import_attributes.type_json
# TODO: Tag javascript.statements.import when https://github.com/web-platform-dx/web-features/issues/1173 is resolved.
2 changes: 0 additions & 2 deletions features/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-main-elem
group: html-elements
# Note: <main> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.main
2 changes: 0 additions & 2 deletions features/mark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-mark-
group: html-elements
# Note: <mark> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.mark
15 changes: 6 additions & 9 deletions features/menu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@ name: <menu>
description: The `<menu>` element represents an unordered list of action items (`<li>`), such as a toolbar. It is a semantic alternative to the `<ul>` element.
spec: https://html.spec.whatwg.org/multipage/grouping-content.html#menus
group: html-elements
compat_features:
- api.HTMLMenuElement
- html.elements.menu
# TODO: Include relevant parts of api.HTMLLIElement when possible:
# https://github.com/web-platform-dx/web-features/issues/1173
# - api.HTMLLIElement
# - api.HTMLLIElement.value
# - html.elements.li
# - html.elements.li.value
# TODO: Tag relevant parts of api.HTMLLIElement when possible:
# https://github.com/web-platform-dx/web-features/issues/1173
# - api.HTMLLIElement
# - api.HTMLLIElement.value
# - html.elements.li
# - html.elements.li.value
2 changes: 0 additions & 2 deletions features/nav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/sections.html#the-nav-element
group: html-elements
# Note: <nav> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.nav
2 changes: 0 additions & 2 deletions features/section.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/sections.html#the-section-element
group: html-elements
# Note: <section> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- html.elements.section
14 changes: 3 additions & 11 deletions features/source.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@ group:
- html-elements
status:
compute_from: html.elements.source
compat_features:
- html.elements.source
- html.elements.source.height
- html.elements.source.media
# Included in srcset (see #1448)
# - html.elements.source.sizes
- html.elements.source.src
# Included in srcset (see #1448)
# - html.elements.source.srcset
- html.elements.source.type
- html.elements.source.width
# Included in srcset (see #1448)
# - html.elements.source.sizes
# - html.elements.source.srcset
5 changes: 0 additions & 5 deletions features/time.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,3 @@ spec: https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-time-
group: html-elements
# Note: <time> is part of https://caniuse.com/html5semantic but that feature
# covers many unrelated elements and is therefore not linked here.
compat_features:
- api.HTMLTimeElement
- api.HTMLTimeElement.dateTime
- html.elements.time
- html.elements.time.datetime

0 comments on commit 3d8b4ff

Please sign in to comment.