Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS and SVG animations, fill missing Web Animations #1771

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Sep 11, 2024

This is mostly backfilling older functionality. It adds a new Animation Group as well.

Low/false baseline items did not seem particularly feature-worthy.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 11, 2024
@@ -0,0 +1,51 @@
name: CSS Animations
description: The `animation` CSS property applies `@keyframes` animation sequences to transform elements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `animation` CSS property applies `@keyframes` animation sequences to transform elements.
description: The `animation` CSS property animates an element's style over time, using keyframes described in `@keyframes` rules.

Wanted to propose an alt description because I wasn't super keen on using the word "transform", since it could be interpreted as CSS transforms. And because I thought it was important to mention the time component of CSS animations, to separate this feature from the scroll-driven animations feature.

@@ -0,0 +1,97 @@
name: SVG animations
description: The `<animate>`, `<animateMotion>`, and `<animateTransform>` SVG elements declaratively animate SVG elements. Also known as SMIL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `<animate>`, `<animateMotion>`, and `<animateTransform>` SVG elements declaratively animate SVG elements. Also known as SMIL.
description: The `<animate>`, `<animateMotion>`, and `<animateTransform>` SVG elements animate an SVG element's attributes over time. Also known as SMIL.

Here I also think we should mention the over time concept, and maybe also mention that it's the attributes that get animated (if I'm not mistaken)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the significance of differentiating between the element and the element's attributes? Perhaps a poor analogy, but I think of it as "You press the gas pedal to turn the wheels" vs "You press the gas pedal to move the car"- the intended outcome is moving the car, and the wheels are somewhat incidental.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what prompted me to talk about attributes is that we describe CSS animations as animating an element's styles.
So, I felt compelled to mention exactly what were SVG animations animating.

Animating an element feels quite abstract to me, but perhaps it's just me. I won't block on this. If you prefer "animate SVG elements", go for it.

features/svg-animations.yml Outdated Show resolved Hide resolved
features/web-animations.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,97 @@
name: SVG animations
description: The `<animate>`, `<animateMotion>`, and `<animateTransform>` SVG elements declaratively animate SVG elements. Also known as SMIL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what prompted me to talk about attributes is that we describe CSS animations as animating an element's styles.
So, I felt compelled to mention exactly what were SVG animations animating.

Animating an element feels quite abstract to me, but perhaps it's just me. I won't block on this. If you prefer "animate SVG elements", go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants