Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm_hover): remove json serialization #6

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

goulvenclech
Copy link
Member

For get_hover in WASM : Embedding JSON data at compile time, modifying the function signature, and updating the benchmark to reflect these changes.

How is it tested?

Through benchmarks.

How is it documented?

A comment was added to the code, and I'll create an issue.

@github-actions github-actions bot added the crt:csslsrs Changes in the CSSlsrs crate. label Dec 4, 2024
@goulvenclech goulvenclech force-pushed the fix_wasm_hover_json_serial branch from 8d4d95e to a9b88c6 Compare December 4, 2024 19:19
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #6 will degrade performances by 37.41%

Comparing fix_wasm_hover_json_serial (a9b88c6) with main (5501f68)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 6 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix_wasm_hover_json_serial Change
CSSLSRS(WASM) - Document colors 39 ms 62.4 ms -37.41%
CSSLSRS(WASM) - Hover 45,593.5 µs 409.2 µs ×110

@Princesseuh Princesseuh merged commit b5e5338 into main Dec 4, 2024
6 of 7 checks passed
@Princesseuh Princesseuh deleted the fix_wasm_hover_json_serial branch December 4, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crt:csslsrs Changes in the CSSlsrs crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants