Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(benchmark): Add benchmark for full language server #15

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Dec 15, 2024

What does this change?

This adds a benchmark suite for the full language server for every kind of request we support right now. In local, much like our WASM benchmarks it compares with VS Code's current implementation.

How is it tested?

N/A

How is it documented?

N/A

@github-actions github-actions bot added the devops Changes in the workflow/ actions/ linters/ releases. label Dec 15, 2024

if (!childProcess.stdout || !childProcess.stdin) {
throw new Error("Bad stdio configuration, should be pipe");
}

if (process.env.DEBUG) {
childProcess.stderr?.on("data", (data) => {
childProcess.stderr?.on("data", (data) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our server currently rely on stderr working, otherwise it panics, oops.

Copy link

codspeed-hq bot commented Dec 15, 2024

CodSpeed Performance Report

Merging #15 will not alter performance

Comparing feat/lsp-benchmarks (41893da) with main (5c9fc27)

Summary

✅ 8 untouched benchmarks
🆕 4 new benchmarks

Benchmarks breakdown

Benchmark main feat/lsp-benchmarks Change
🆕 weblsp - Color Presentation N/A 948.1 µs N/A
🆕 weblsp - Document Colors N/A 1.7 ms N/A
🆕 weblsp - Folding Ranges N/A 777.6 µs N/A
🆕 weblsp - Hover N/A 1.9 ms N/A

@goulvenclech goulvenclech merged commit e4880c7 into main Dec 15, 2024
7 checks passed
@goulvenclech goulvenclech deleted the feat/lsp-benchmarks branch December 15, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Changes in the workflow/ actions/ linters/ releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants