refactor: remove auto detect esmodule #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the early days, SWC has an issue that is it injected
__esModule
unexpectedly, see here, so at that time, I useis_esm
to check if the input code is esModule or not, if it isn't, then__esModule
should not present in the exports, and I can remove it in the output code.However this detection is not robust enough, it did not take
import.meta
andtop-level-await
into account, thank @咲奈Sakina for mentioning this.Now, SWC fixed this issue, and we no longer need this behavior.