Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightning css): align type with lightning documentation #8197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zackarychapple
Copy link
Collaborator

Summary

In the lightning css documentation there is a option to enable drafts. This option was incorrectly named as draft instead of drafts. Updated the typing to the proper name as per the documentation.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3878720
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6717b372ac87f900084dc032

@hardfist
Copy link
Contributor

even it's a typo, this change is still a breaking change, we can try to be compatible by supporting both draft and drafts and mark draft deprecated and remove it in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants