-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(plugin/css-extract): use typescript for css-extract-hmr #7245
refactor(plugin/css-extract): use typescript for css-extract-hmr #7245
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
c525e43
to
a442d81
Compare
My bad 💀, I had to rebuild the packages |
packages/rspack-test-tools/tests/hotCases/css/recovery/__snapshots__/web/2.snap.txt
Outdated
Show resolved
Hide resolved
packages/rspack/src/builtin-plugin/css-extract/hmr/hotModuleReplacement.ts
Outdated
Show resolved
Hide resolved
packages/rspack/src/builtin-plugin/css-extract/hmr/normalize-url.ts
Outdated
Show resolved
Hide resolved
packages/rspack/src/builtin-plugin/css-extract/hmr/hotModuleReplacement.ts
Outdated
Show resolved
Hide resolved
fab4da0
to
4261871
Compare
This reverts commit e9ba349.
9116622
to
10e2a96
Compare
I made some modifications and passed the CI, and you can review the code |
WIll this cause problems for you ? Runtime api has small changes, and become esm @colinaaa |
Thanks for letting me know. This PR LGTM. We are using our own runtime for CSS extract. |
You may also want to port this: webpack-contrib/mini-css-extract-plugin#1090 😄 |
Summary
Checklist