Skip to content

fix: truncate width into u16::MAX for graphical reporter #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: truncate width into u16::MAX for graphical reporter #10180

merged 1 commit into from
Apr 25, 2025

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Apr 25, 2025

Summary

closes #10150

truncate width into u16::MAX for graphical reporter.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 25, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6bee9d5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680b2a388b59b600084d7e9c
😎 Deploy Preview https://deploy-preview-10180--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a h-a-n-a enabled auto-merge (squash) April 25, 2025 06:31
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #10180 will not alter performance

Comparing fix-graphical (6bee9d5) with main (ad6d0de)

Summary

✅ 11 untouched benchmarks

chenjiahan
chenjiahan approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JSerFeng JSerFeng mentioned this pull request Apr 25, 2025
Closed
@h-a-n-a h-a-n-a merged commit 96b5d0b into main Apr 25, 2025
38 checks passed
@h-a-n-a h-a-n-a deleted the fix-graphical branch April 25, 2025 06:47
@chenjiahan chenjiahan mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Build fails at end
2 participants
@h-a-n-a @chenjiahan