Skip to content

Commit

Permalink
fix(create-rspack): eslint-plugin-react-hooks version conflict (#7854)
Browse files Browse the repository at this point in the history
* fix(create-rspack): eslint-plugin-react-hooks version conflict

* fix

* fix: comment
  • Loading branch information
chenjiahan authored Sep 11, 2024
1 parent f5c6a1b commit 930e351
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 179 deletions.
4 changes: 2 additions & 2 deletions packages/create-rspack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"dev": "rslib build -w"
},
"dependencies": {
"create-rstack": "1.0.1"
"create-rstack": "1.0.2"
},
"devDependencies": {
"@rslib/core": "0.0.3",
"@rslib/core": "0.0.5",
"typescript": "5.0.2"
},
"publishConfig": {
Expand Down
1 change: 0 additions & 1 deletion packages/create-rspack/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env node
import path from "node:path";
import {
type Argv,
Expand Down
Loading

2 comments on commit 930e351

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-09-11 f5c6a1b) Current Change
10000_development-mode + exec 2.24 s ± 48 ms 2.24 s ± 28 ms -0.13 %
10000_development-mode_hmr + exec 722 ms ± 7.4 ms 727 ms ± 12 ms +0.70 %
10000_production-mode + exec 2.86 s ± 47 ms 2.84 s ± 32 ms -0.40 %
arco-pro_development-mode + exec 1.85 s ± 81 ms 1.83 s ± 80 ms -1.20 %
arco-pro_development-mode_hmr + exec 435 ms ± 4 ms 435 ms ± 1.6 ms +0.02 %
arco-pro_production-mode + exec 3.26 s ± 99 ms 3.27 s ± 67 ms +0.47 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.34 s ± 76 ms 3.32 s ± 75 ms -0.63 %
threejs_development-mode_10x + exec 1.68 s ± 13 ms 1.69 s ± 15 ms +0.09 %
threejs_development-mode_10x_hmr + exec 805 ms ± 13 ms 806 ms ± 8.4 ms +0.15 %
threejs_production-mode_10x + exec 5.19 s ± 23 ms 5.19 s ± 23 ms +0.07 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rslib ❌ failure
rsbuild ❌ failure
examples ✅ success

Please sign in to comment.