fix: perf bug for large replace source #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix web-infra-dev/rspack#9137
In Rspack's source code, the
check_content_at_position
function is used to check whether thesourceContent
in the source map matches the original source code. If they match, additional mapping information can be added.The
check_content_at_position
function usescolumn
(character index) to extract substrings fromsourceContent
. Sincecolumn
is a character index and strings are stored as byte indices, a conversion from byte index to character index is required. This conversion process has become a performance bottleneck.By caching the conversion results from byte index to character index, redundant calculations are avoided, thereby improving performance.