Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: get the default asset when first load page #692

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

easy1090
Copy link
Contributor

Summary

optimize: get the default asset when first load page

Related Links

@easy1090 easy1090 requested a review from nyqykk January 12, 2025 14:54
Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit 5b06e57
🔍 Latest deploy log https://app.netlify.com/sites/rsdoctor/deploys/6784a0b3add9840008659a7a
😎 Deploy Preview https://deploy-preview-692--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@easy1090 easy1090 requested a review from chenjiahan January 13, 2025 03:40
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the background to this change in the PR description?

@easy1090
Copy link
Contributor Author

easy1090 commented Jan 13, 2025

Can you explain the background to this change in the PR description?

OK, when open the bundle size page, the modules tree is always empty, this will reduce the page not good. So I want to set a default asset's modules tree.

image

@easy1090 easy1090 requested a review from chenjiahan January 13, 2025 03:54
@easy1090 easy1090 force-pushed the opt/bundle-size-page branch from 99ad70f to 8b1c617 Compare January 13, 2025 05:09
@easy1090 easy1090 requested a review from chenjiahan January 13, 2025 05:12
@chenjiahan chenjiahan merged commit 75fb852 into main Jan 13, 2025
7 checks passed
@chenjiahan chenjiahan deleted the opt/bundle-size-page branch January 13, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants