Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-plugin): fix multi-plugin options error #608

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

easy1090
Copy link
Contributor

@easy1090 easy1090 commented Nov 28, 2024

Summary

Fix the error when options is reportCodeType: { noCode: true } and use the multi-plugin.

Enhancements to rsdoctor plugins and configurations:

  • e2e/cases/doctor-webpack/plugins/multi-plugin-brief.test.ts: Added a new test case for the rsdoctor webpack plugin with brief mode options.

  • e2e/cases/doctor-webpack/test-utils.ts: Introduced a new createRsdoctorMultiPlugin function to create instances of RsdoctorWebpackMultiplePlugin with enhanced options.

  • packages/sdk/src/sdk/multiple/slave.ts: Updated the RsdoctorPrimarySDK class to include the type property in the constructor and initialization. [1] [2] [3]

  • packages/webpack-plugin/src/multiple.ts and packages/rspack-plugin/src/multiple.ts: Enhanced the RsdoctorWebpackMultiplePlugin and RsdoctorRspackMultiplePlugin classes to normalize user configurations and support additional options such as disableTOSUpload, innerClientPath, printLog, mode, and brief. [1] [2]

Updates to Husky hooks: typicode/husky#1480

Related Links

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit a562eda
🔍 Latest deploy log https://app.netlify.com/sites/rsdoctor/deploys/6748494bde9be10008269f8d
😎 Deploy Preview https://deploy-preview-608--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@easy1090 easy1090 requested a review from nyqykk November 28, 2024 08:45
@easy1090 easy1090 force-pushed the fix/multi-plugin-options branch from 3a1219f to 42e1890 Compare November 28, 2024 08:47
@easy1090 easy1090 removed the request for review from SoonIter November 28, 2024 10:05
fix(multi-plugin): fix multi-plugin options error

fix(multi-plugin): fix multi-plugin options error

fix(multi-plugin): fix multi-plugin options error

fix(multi-plugin): fix multi-plugin options error
@easy1090 easy1090 force-pushed the fix/multi-plugin-options branch from 3c324b3 to 19b5b06 Compare November 28, 2024 10:05
const instance = controller.createSlave({
name: options.name || 'Builder',
stage: options.stage,
extraConfig: { disableTOSUpload: options.disableTOSUpload || false },
extraConfig: {
disableTOSUpload: normallizedOptions.disableTOSUpload || false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This options should be removed

@easy1090 easy1090 merged commit 890871e into main Dec 2, 2024
9 checks passed
@easy1090 easy1090 deleted the fix/multi-plugin-options branch December 2, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants