-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-less): lessLoaderOptions.lessOptions.plugins has lose it's prototype. #3815
base: main
Are you sure you want to change the base?
fix(plugin-less): lessLoaderOptions.lessOptions.plugins has lose it's prototype. #3815
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/plugin-less/src/index.ts
Outdated
@@ -75,7 +75,11 @@ const getLessLoaderOptions = ( | |||
): LessLoaderOptions => { | |||
const getLessOptions = () => { | |||
if (defaults.lessOptions && userOptions.lessOptions) { | |||
return deepmerge(defaults.lessOptions, userOptions.lessOptions); | |||
return deepmerge(defaults.lessOptions, userOptions.lessOptions, { | |||
isMergeableObject: (obj) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the internal isPlainObject
helper here?
The same as
isMergeableObject: isPlainObject, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, of course.
cac000a
to
6c5b370
Compare
24a31f1
to
e0f07ea
Compare
Summary
fix the
deepmerge
to judge whether is an plain object.Related Links
#3810
Checklist