Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-rsbuild): broken shebang line in bin file #3344

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(create-rsbuild): broken shebang line in bin file #3344

merged 1 commit into from
Sep 2, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Sep 2, 2024 •
edited
Loading

Summary

Fix Rslib breaks bin shebang line.

image

Related Links

web-infra-dev/rslib#166

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan changed the title fix(create-rsbuild): broken bin comments fix(create-rsbuild): broken bin comment Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit e6b0e85
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66d5272f2bba610008194157
😎 Deploy Preview https://deploy-preview-3344--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 75 (🟢 up 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix(create-rsbuild): broken bin comment fix(create-rsbuild): broken shebang line in bin file Sep 2, 2024
@chenjiahan chenjiahan merged commit aefefd5 into main Sep 2, 2024
12 of 13 checks passed
@chenjiahan chenjiahan deleted the create_rsbuild_bin_0902 branch September 2, 2024 02:49
@chenjiahan chenjiahan mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chenjiahan