Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): support launch editor #1381

Merged
merged 2 commits into from
Jan 21, 2024
Merged

feat(server): support launch editor #1381

merged 2 commits into from
Jan 21, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Integrate https://www.npmjs.com/package/launch-editor-middleware to support launch editor.

The middleware will be enabled by default in the Rsbuild core, as many tools already use it to open the editor, see:
https://github.com/search?q=__open-in-editor&type=code

Related Links

close #1376

Checklist

  • Tests updated.
  • Documentation updated.

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a08ffb5
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/65ac755dc38a6400084e3929
😎 Deploy Preview https://deploy-preview-1381--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan
Copy link
Member Author

@9aoy I have modified the return type of getMiddlewares to support passing path string.

If you have a better solution for this, feel free to adjust the implementation.

@chenjiahan chenjiahan merged commit ddd2078 into main Jan 21, 2024
10 checks passed
@chenjiahan chenjiahan deleted the open_in_editor_0121 branch January 21, 2024 01:46
@chenjiahan chenjiahan mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: plugin-vue/vue2 添加 launch-editor-middleware
1 participant