fix(mf): should compile @module-federation/sdk (#3270)

web-infra-dev · Aug 23, 2024 · e7b8758 · e7b8758
1 parent 0e8ad94
commit e7b8758
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 35 deletions.
diff --git a/e2e/cases/module-federation/index.test.ts b/e2e/cases/module-federation/index.test.ts
@@ -93,45 +93,47 @@ rspackOnlyTest(
   },
 );
 
-// TODO: fix this test
-test.fail('should transform module federation runtime with SWC', async () => {
-  writeButtonCode();
+rspackOnlyTest(
+  'should transform module federation runtime with SWC',
+  async () => {
+    writeButtonCode();
 
-  const remotePort = await getRandomPort();
+    const remotePort = await getRandomPort();
 
-  process.env.REMOTE_PORT = remotePort.toString();
+    process.env.REMOTE_PORT = remotePort.toString();
 
-  await expect(
-    build({
-      cwd: remote,
-      rsbuildConfig: {
-        output: {
-          overrideBrowserslist: ['Chrome >= 51'],
-        },
-        performance: {
-          chunkSplit: {
-            strategy: 'all-in-one',
+    await expect(
+      build({
+        cwd: remote,
+        rsbuildConfig: {
+          output: {
+            overrideBrowserslist: ['Chrome >= 51'],
           },
+          performance: {
+            chunkSplit: {
+              strategy: 'all-in-one',
+            },
+          },
+          plugins: [pluginCheckSyntax()],
         },
-        plugins: [pluginCheckSyntax()],
-      },
-    }),
-  ).resolves.toBeTruthy();
-
-  await expect(
-    build({
-      cwd: host,
-      rsbuildConfig: {
-        output: {
-          overrideBrowserslist: ['Chrome >= 51'],
-        },
-        performance: {
-          chunkSplit: {
-            strategy: 'all-in-one',
+      }),
+    ).resolves.toBeTruthy();
+
+    await expect(
+      build({
+        cwd: host,
+        rsbuildConfig: {
+          output: {
+            overrideBrowserslist: ['Chrome >= 51'],
           },
+          performance: {
+            chunkSplit: {
+              strategy: 'all-in-one',
+            },
+          },
+          plugins: [pluginCheckSyntax()],
         },
-        plugins: [pluginCheckSyntax()],
-      },
-    }),
-  ).resolves.toBeTruthy();
-});
+      }),
+    ).resolves.toBeTruthy();
+  },
+);
diff --git a/packages/core/src/plugins/moduleFederation.ts b/packages/core/src/plugins/moduleFederation.ts
@@ -130,6 +130,7 @@ export function pluginModuleFederation(): RsbuildPlugin {
         // adding to include and let SWC transform it
         config.source.include = [
           ...(config.source.include || []),
+          /@module-federation[\\/]sdk/,
           /@module-federation[\\/]runtime/,
         ];
       });