Skip to content

Commit

Permalink
chore: remove lightningcss minimizer exclude (#3555)
Browse files Browse the repository at this point in the history
  • Loading branch information
@chenjiahan
chenjiahan authored Sep 25, 2024
1 parent 67fb63a commit 9981cea
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 153 deletions.
28 changes: 0 additions & 28 deletions packages/core/src/plugins/minimize.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,34 +114,6 @@ export const pluginMinimize = (): RsbuildPlugin => ({
const defaultOptions: LightningCssMinimizerRspackPluginOptions = {
minimizerOptions: {
targets: environment.browserslist,
// TODO: The exclude option of Lightning CSS does not work as expected
// so we need to disable all excludes and figure out how to skip the transformation
// see: https://github.com/parcel-bundler/lightningcss/issues/792
exclude: {
nesting: false,
notSelectorList: false,
dirSelector: false,
langSelectorList: false,
isSelector: false,
textDecorationThicknessPercent: false,
mediaIntervalSyntax: false,
mediaRangeSyntax: false,
customMediaQueries: false,
clampFunction: false,
colorFunction: false,
oklabColors: false,
labColors: false,
p3Colors: false,
hexAlphaColors: false,
spaceSeparatedColorNotation: false,
fontFamilySystemUi: false,
doublePositionGradients: false,
vendorPrefixes: false,
logicalProperties: false,
selectors: false,
mediaQueries: false,
color: false,
},
},
};

Expand Down
25 changes: 0 additions & 25 deletions packages/core/tests/__snapshots__/default.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -696,31 +696,6 @@ exports[`applyDefaultPlugins > should apply default plugins correctly when prod
"_args": [
{
"minimizerOptions": {
"exclude": {
"clampFunction": false,
"color": false,
"colorFunction": false,
"customMediaQueries": false,
"dirSelector": false,
"doublePositionGradients": false,
"fontFamilySystemUi": false,
"hexAlphaColors": false,
"isSelector": false,
"labColors": false,
"langSelectorList": false,
"logicalProperties": false,
"mediaIntervalSyntax": false,
"mediaQueries": false,
"mediaRangeSyntax": false,
"nesting": false,
"notSelectorList": false,
"oklabColors": false,
"p3Colors": false,
"selectors": false,
"spaceSeparatedColorNotation": false,
"textDecorationThicknessPercent": false,
"vendorPrefixes": false,
},
"targets": [
"chrome >= 87",
"edge >= 88",
Expand Down
100 changes: 0 additions & 100 deletions packages/core/tests/minimize.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,31 +46,6 @@ describe('plugin-minimize', () => {
"_args": [
{
"minimizerOptions": {
"exclude": {
"clampFunction": false,
"color": false,
"colorFunction": false,
"customMediaQueries": false,
"dirSelector": false,
"doublePositionGradients": false,
"fontFamilySystemUi": false,
"hexAlphaColors": false,
"isSelector": false,
"labColors": false,
"langSelectorList": false,
"logicalProperties": false,
"mediaIntervalSyntax": false,
"mediaQueries": false,
"mediaRangeSyntax": false,
"nesting": false,
"notSelectorList": false,
"oklabColors": false,
"p3Colors": false,
"selectors": false,
"spaceSeparatedColorNotation": false,
"textDecorationThicknessPercent": false,
"vendorPrefixes": false,
},
"targets": [
"chrome >= 87",
"edge >= 88",
Expand Down Expand Up @@ -229,31 +204,6 @@ describe('plugin-minimize', () => {
"_args": [
{
"minimizerOptions": {
"exclude": {
"clampFunction": false,
"color": false,
"colorFunction": false,
"customMediaQueries": false,
"dirSelector": false,
"doublePositionGradients": false,
"fontFamilySystemUi": false,
"hexAlphaColors": false,
"isSelector": false,
"labColors": false,
"langSelectorList": false,
"logicalProperties": false,
"mediaIntervalSyntax": false,
"mediaQueries": false,
"mediaRangeSyntax": false,
"nesting": false,
"notSelectorList": false,
"oklabColors": false,
"p3Colors": false,
"selectors": false,
"spaceSeparatedColorNotation": false,
"textDecorationThicknessPercent": false,
"vendorPrefixes": false,
},
"targets": [
"chrome >= 87",
"edge >= 88",
Expand Down Expand Up @@ -314,31 +264,6 @@ describe('plugin-minimize', () => {
"_args": [
{
"minimizerOptions": {
"exclude": {
"clampFunction": false,
"color": false,
"colorFunction": false,
"customMediaQueries": false,
"dirSelector": false,
"doublePositionGradients": false,
"fontFamilySystemUi": false,
"hexAlphaColors": false,
"isSelector": false,
"labColors": false,
"langSelectorList": false,
"logicalProperties": false,
"mediaIntervalSyntax": false,
"mediaQueries": false,
"mediaRangeSyntax": false,
"nesting": false,
"notSelectorList": false,
"oklabColors": false,
"p3Colors": false,
"selectors": false,
"spaceSeparatedColorNotation": false,
"textDecorationThicknessPercent": false,
"vendorPrefixes": false,
},
"targets": [
"chrome >= 87",
"edge >= 88",
Expand Down Expand Up @@ -393,31 +318,6 @@ describe('plugin-minimize', () => {
"_args": [
{
"minimizerOptions": {
"exclude": {
"clampFunction": false,
"color": false,
"colorFunction": false,
"customMediaQueries": false,
"dirSelector": false,
"doublePositionGradients": false,
"fontFamilySystemUi": false,
"hexAlphaColors": false,
"isSelector": false,
"labColors": false,
"langSelectorList": false,
"logicalProperties": false,
"mediaIntervalSyntax": false,
"mediaQueries": false,
"mediaRangeSyntax": false,
"nesting": false,
"notSelectorList": false,
"oklabColors": false,
"p3Colors": false,
"selectors": false,
"spaceSeparatedColorNotation": false,
"textDecorationThicknessPercent": false,
"vendorPrefixes": false,
},
"targets": [
"chrome >= 87",
"edge >= 88",
Expand Down

0 comments on commit 9981cea

Please sign in to comment.