perf: make open browser faster (#404)

.changeset/honest-elephants-move.md

@@ -0,0 +1,5 @@
+---
+'@rsbuild/core': patch
+---
+
+perf: make open browser faster

cspell.json

@@ -6,6 +6,7 @@
   // words - list of words to be always considered correct
   "words": [
     "antd",
+    "applescript",
     "atrules",
     "deepmerge",
     "docgen",
@@ -24,6 +25,7 @@
     "onclosetag",
     "onopentag",
     "ontext",
+    "osascript",
     "outro",
     "oxlint",
     "pluggable",

packages/core/src/plugins/startUrl.ts

@@ -1,6 +1,9 @@
 import { join } from 'path';
 import { logger, castArray, type DefaultRsbuildPlugin } from '@rsbuild/shared';
-import { execSync } from 'child_process';
+import { exec } from 'child_process';
+import { promisify } from 'util';
+
+const execAsync = promisify(exec);
 
 const supportedChromiumBrowsers = [
   'Google Chrome Canary',
@@ -13,12 +16,12 @@ const supportedChromiumBrowsers = [
   'Chromium',
 ];
 
-const getTargetBrowser = () => {
+const getTargetBrowser = async () => {
   // Use user setting first
   let targetBrowser = process.env.BROWSER;
   // If user setting not found or not support, use opening browser first
   if (!targetBrowser || !supportedChromiumBrowsers.includes(targetBrowser)) {
-    const ps = execSync('ps cax').toString();
+    const { stdout: ps } = await execAsync('ps cax');
     targetBrowser = supportedChromiumBrowsers.find((b) => ps.includes(b));
   }
   return targetBrowser;
@@ -41,18 +44,18 @@ export async function openBrowser(url: string): Promise<boolean> {
 
   if (shouldTryOpenChromeWithAppleScript) {
     try {
-      const targetBrowser = getTargetBrowser();
+      const targetBrowser = await getTargetBrowser();
       if (targetBrowser) {
         // Try to reuse existing tab with AppleScript
-        execSync(
+        await execAsync(
           `osascript openChrome.applescript "${encodeURI(
             url,
           )}" "${targetBrowser}"`,
           {
-            stdio: 'ignore',
             cwd: join(__dirname, '../../static'),
           },
         );
+
         return true;
       }
       return false;
@@ -85,17 +88,8 @@ export function pluginStartUrl(): DefaultRsbuildPlugin {
   return {
     name: 'plugin-start-url',
     setup(api) {
-      let port: number;
-
       api.onAfterStartDevServer(async (params) => {
-        ({ port } = params);
-      });
-
-      api.onDevCompileDone(async ({ isFirstCompile }) => {
-        if (!isFirstCompile || !port) {
-          return;
-        }
-
+        const { port } = params;
         const config = api.getNormalizedConfig();
         const { startUrl, beforeStartUrl } = config.dev;
         const { open, https } = api.context.devServer || {};

packages/core/tests/rspack-provider/plugins/__snapshots__/default.test.ts.snap

@@ -1352,7 +1352,7 @@ exports[`applyDefaultPlugins > should apply default plugins correctly when prod
 }
 `;
 
-exports[`applyDefaultPlugins > should apply default plugins correctyly when target = node 1`] = `
+exports[`applyDefaultPlugins > should apply default plugins correctly when target = node 1`] = `
 {
   "builtins": {
     "css": {

packages/core/tests/rspack-provider/plugins/default.test.ts

@@ -26,7 +26,7 @@ describe('applyDefaultPlugins', () => {
     process.env.NODE_ENV = NODE_ENV;
   });
 
-  it('should apply default plugins correctyly when target = node', async () => {
+  it('should apply default plugins correctly when target = node', async () => {
     const { NODE_ENV } = process.env;
     process.env.NODE_ENV = 'test';
     const rsbuild = await createStubRsbuild({