chore: enable TS no unused check (#586)

web-infra-dev · Nov 19, 2023 · 141e500 · 141e500
1 parent 9e959d0
commit 141e500
Show file tree

Hide file tree

Showing 20 changed files with 16 additions and 26 deletions.
diff --git a/packages/compat/uni-builder/src/webpack/webpackPlugins/ModuleScopePlugin.ts b/packages/compat/uni-builder/src/webpack/webpackPlugins/ModuleScopePlugin.ts
@@ -44,7 +44,7 @@ export class ModuleScopePlugin {
       this;
     resolver.hooks.file.tapAsync(
       'ModuleScopePlugin',
-      (request: any, contextResolver: any, callback: any) => {
+      (request: any, _context: unknown, callback: any) => {
         const { issuer } = request.context;
 
         // Unknown issuer, probably webpack internals

diff --git a/packages/compat/webpack/src/plugins/css.ts b/packages/compat/webpack/src/plugins/css.ts
@@ -39,8 +39,6 @@ export async function applyBaseCSSRule({
 
   // 1. Check user config
   const enableExtractCSS = isUseCssExtract(config, target);
-  const enableCssMinify = !enableExtractCSS && isProd;
-
   const enableSourceMap = isUseCssSourceMap(config);
   const enableCSSModuleTS = Boolean(config.output.enableCssModuleTSDeclaration);
 
@@ -122,7 +120,6 @@ export async function applyBaseCSSRule({
       enableSourceMap,
       browserslist,
       config,
-      enableCssMinify,
     });
 
     rule

diff --git a/packages/compat/webpack/src/plugins/progress.ts b/packages/compat/webpack/src/plugins/progress.ts
@@ -1,4 +1,4 @@
-import { TARGET_ID_MAP, isProd } from '@rsbuild/shared';
+import { TARGET_ID_MAP } from '@rsbuild/shared';
 import type { RsbuildPlugin } from '../types';
 
 export const pluginProgress = (): RsbuildPlugin => ({

diff --git a/packages/core/src/rspack-provider/plugins/css.ts b/packages/core/src/rspack-provider/plugins/css.ts
@@ -38,7 +38,6 @@ export async function applyBaseCSSRule({
   importLoaders?: number;
 }) {
   // 1. Check user config
-  const enableExtractCSS = isUseCssExtract(config, target);
   const enableSourceMap = isUseCssSourceMap(config);
   const enableCSSModuleTS = Boolean(config.output.enableCssModuleTSDeclaration);
 
@@ -48,8 +47,6 @@ export async function applyBaseCSSRule({
     target,
   );
 
-  const enableCssMinify = !enableExtractCSS && isProd;
-
   // when disableExtractCSS, use css-loader + style-loader
   if (!enableNativeCss(config)) {
     const localIdentName = getCssModuleLocalIdentName(config, isProd);
@@ -130,7 +127,6 @@ export async function applyBaseCSSRule({
       enableSourceMap,
       browserslist,
       config,
-      enableCssMinify,
     });
 
     rule

diff --git a/packages/doctor-core/src/inner-plugins/utils/plugin.ts b/packages/doctor-core/src/inner-plugins/utils/plugin.ts
@@ -9,7 +9,7 @@ export function reportPluginData(
   tapName: string,
   start: number,
   type: SDK.PluginHookData['type'],
-  res: unknown,
+  _res: unknown,
   err?: Error,
 ) {
   const end = Date.now();

diff --git a/packages/doctor-sdk/src/sdk/sdk/core.ts b/packages/doctor-sdk/src/sdk/sdk/core.ts
@@ -113,7 +113,7 @@ export abstract class SDKCore<T extends DoctorSDKOptions>
   /** Upload analysis data pieces */
   protected async writePieces(
     storeData: Common.PlainObject,
-    options?: SDK.WriteStoreOptionsType,
+    _options?: SDK.WriteStoreOptionsType,
   ) {
     const { outputDir } = this;
     const manifest = path.resolve(outputDir, Constants.DoctorOutputManifest);

diff --git a/packages/doctor-sdk/src/sdk/sdk/webpack.ts b/packages/doctor-sdk/src/sdk/sdk/webpack.ts
@@ -425,7 +425,7 @@ export class DoctorWebpackSDK<
   }
 
   public getRuleContext(
-    options: SDK.RuntimeContextOptions,
+    _options: SDK.RuntimeContextOptions,
   ): SDK.RuntimeContext {
     this.createPackageGraph();
 

diff --git a/packages/doctor-sdk/src/sdk/server/index.ts b/packages/doctor-sdk/src/sdk/server/index.ts
@@ -3,7 +3,7 @@ import { Server } from '@rsbuild/doctor-utils/build';
 import { Bundle } from '@rsbuild/doctor-utils/common';
 import assert from 'assert';
 import bodyParser from 'body-parser';
-import open from 'open';
+// import open from 'open';
 import ip from 'ip';
 import cors from 'cors';
 import { PassThrough } from 'stream';

diff --git a/packages/doctor-utils/src/common/data/index.ts b/packages/doctor-utils/src/common/data/index.ts
@@ -188,7 +188,6 @@ export class APIDataLoader {
         ]).then((res) => {
           const { moduleId } =
             body as SDK.ServerAPI.InferRequestBodyType<SDK.ServerAPI.API.GetModuleDetails>;
-          const { chunks = [] } = res[0] || {};
           const { modules = [], dependencies = [] } = res[1] || {};
           return Graph.getModuleDetails(moduleId, modules, dependencies) as R;
         });
@@ -297,7 +296,7 @@ export class APIDataLoader {
           this.loader.loadData('configs'),
         ]).then(
           ([
-            manifest,
+            _manifest,
             root = '',
             hash = '',
             errors = {},

diff --git a/packages/doctor-webpack-plugin/src/multiple.ts b/packages/doctor-webpack-plugin/src/multiple.ts
@@ -9,6 +9,7 @@ let globalController: DoctorSDKController | undefined;
 export class RsbuildDoctorWebpackMultiplePlugin<
   Rules extends Linter.ExtendRuleData[],
 > extends RsbuildDoctorWebpackPlugin<Rules> {
+  // @ts-expect-error
   private controller: DoctorSDKController;
 
   constructor(options: DoctorWebpackMultiplePluginOptions<Rules> = {}) {

diff --git a/packages/doctor-webpack-plugin/src/plugins/resolver.ts b/packages/doctor-webpack-plugin/src/plugins/resolver.ts
@@ -178,7 +178,7 @@ export class DoctorResolverPlugin implements ResolvePluginInstance {
       }
     });
 
-    resolver.hooks.resolveStep.tap(this.tapOptions, (hook, request) => {
+    resolver.hooks.resolveStep.tap(this.tapOptions, (_, request) => {
       const { context } = request as unknown as ResolveRequestWithContext;
       if (context.issuer && !this.contextMap.has(context.issuer)) {
         this.contextMap.set(context.issuer, [Date.now(), process.hrtime()]);

diff --git a/packages/plugin-babel/src/types.ts b/packages/plugin-babel/src/types.ts
@@ -1,4 +1,4 @@
-import type { ChainedConfig, ChainedConfigWithUtils } from '@rsbuild/shared';
+import type { ChainedConfigWithUtils } from '@rsbuild/shared';
 import type {
   PluginItem as BabelPlugin,
   PluginOptions as BabelPluginOptions,

diff --git a/packages/shared/src/apply/resolve.ts b/packages/shared/src/apply/resolve.ts
@@ -10,7 +10,7 @@ import {
 } from '../types';
 
 export function applyResolvePlugin(api: SharedRsbuildPluginAPI) {
-  api.modifyBundlerChain((chain, { target, CHAIN_ID }) => {
+  api.modifyBundlerChain((chain, { CHAIN_ID }) => {
     const config = api.getNormalizedConfig();
     const isTsProject = Boolean(api.context.tsconfigPath);
     applyExtensions({

diff --git a/packages/shared/src/config.ts b/packages/shared/src/config.ts
@@ -16,7 +16,6 @@ import {
   DEFAULT_ASSET_PREFIX,
 } from './constants';
 import type {
-  RsbuildTarget,
   BundlerChainRule,
   RsbuildConfig,
   InspectConfigOptions,

diff --git a/packages/shared/src/css.ts b/packages/shared/src/css.ts
@@ -5,7 +5,6 @@ import deepmerge from '../compiled/deepmerge';
 import { getSharedPkgCompiledPath as getCompiledPath } from './utils';
 import { mergeChainedOptions } from './mergeChainedOptions';
 import type {
-  CssModules,
   RsbuildTarget,
   CSSLoaderOptions,
   NormalizedConfig,
@@ -70,12 +69,10 @@ export const getCssnanoDefaultOptions = (): CssNanoOptions => ({
 });
 
 export const getPostcssConfig = ({
-  enableCssMinify,
   enableSourceMap,
   browserslist,
   config,
 }: {
-  enableCssMinify: boolean;
   enableSourceMap: boolean;
   browserslist: string[];
   config: NormalizedConfig;

diff --git a/packages/shared/src/types/config/source.ts b/packages/shared/src/types/config/source.ts
@@ -1,4 +1,4 @@
-import type { RsbuildEntry, RsbuildTarget } from '../rsbuild';
+import type { RsbuildEntry } from '../rsbuild';
 import type { ChainedConfig } from '../utils';
 
 export type Alias = Record<string, string | false | (string | false)[]>;

diff --git a/packages/shared/src/types/hooks.ts b/packages/shared/src/types/hooks.ts
@@ -4,7 +4,6 @@ import { NodeEnv, PromiseOrNot } from './utils';
 import { RsbuildTarget } from './rsbuild';
 import { BundlerChain } from './bundlerConfig';
 import { mergeRsbuildConfig } from '../mergeRsbuildConfig';
-import type { RspackPluginInstance } from '@rspack/core';
 
 export type OnBeforeBuildFn<BundlerConfig = unknown> = (params: {
   bundlerConfigs?: BundlerConfig[];

diff --git a/packages/test-helper/src/index.ts b/packages/test-helper/src/index.ts
@@ -50,7 +50,7 @@ export function createSnapshotSerializer(options?: SnapshotSerializerOptions) {
     { mark: 'root', match: cwd },
     { mark: 'workspace', match: workspace },
     ...customMatchers,
-    ...createDefaultPathMatchers(workspace),
+    ...createDefaultPathMatchers(),
   ];
 
   pathMatchers

diff --git a/packages/test-helper/src/pathSerializer.ts b/packages/test-helper/src/pathSerializer.ts
@@ -50,7 +50,7 @@ export function applyMatcherReplacement(
   }, str);
 }
 
-export const createDefaultPathMatchers = (root: string) => {
+export const createDefaultPathMatchers = () => {
   const ret: PathMatcher[] = [
     {
       match: /(?<=\/)(\.pnpm\/.+?\/node_modules)(?=\/)/,

diff --git a/scripts/tsconfig/base.json b/scripts/tsconfig/base.json
@@ -8,6 +8,8 @@
     "isolatedModules": true,
     "esModuleInterop": true,
     "skipLibCheck": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
     "jsx": "preserve",
     "resolveJsonModule": true,
     "moduleResolution": "Bundler"