Added instructions for targeting .Net 6 in .csproj file #24
Conversation
rabadashTheFool
force-pushed
the
target-net6
branch
from
a853652 to
6fa7992
Compare
…csproj file Signed-off-by: Mihkel Kivisild [email protected]
rabadashTheFool
force-pushed
the
target-net6
branch
from
6fa7992 to
dbf9bec
Compare
|
|
||
| <PackageReference Include="Microsoft.Identity.Web" Version="2.20.0" /> | ||
| <PackageReference Include="Microsoft.Identity.Web.UI" Version="2.20.0" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.21.0" /> |
There was a problem hiding this comment.
Do you know why we need some VS Azure container tool APIs?
There was a problem hiding this comment.
I think we do not need them. Removing them did not stop the build from succeeding.
It might be something that Microsoft added to their Asp .Net template, since this has been there since the first version of the project file.
There was a problem hiding this comment.
Right, got it. Let's remove everything that is not strictly needed when we update the authtoken validation library to the new upcoming version.
There was a problem hiding this comment.
I researched a bit more. Initially it seems it is not required, however if the developer wants to use Docker related tools within Visual Studio, then it will not work without it. It is added by default when creating a new project and selecting "Enable container support".
Dockerizing with CLI tools works regardless.
|
I think we can close this pull request, since we are not endorsing, and do not aspire to do so, using .Net 6. |
|
Only needed for testers. There is no valid reason for adding it into the repository itself, especially as .Net 6 EOL is nearing. |
Added instructions for targeting .Net 6 in .csproj file
Signed-off-by: Mihkel Kivisild [email protected]