Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Commit

Permalink
Change phpseclib dependency to 3.0.*, include composer.lock, explain …
Browse files Browse the repository at this point in the history
…this in README

WE2-876

Signed-off-by: Mart Somermaa <[email protected]>
  • Loading branch information
mrts committed Mar 8, 2024
1 parent a8cdadc commit 37447cd
Show file tree
Hide file tree
Showing 4 changed files with 1,900 additions and 2 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
composer.lock
.phpunit.result.cache
.phpunit.cache/
vendor
Expand Down
21 changes: 21 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,27 @@ try {
}
```

# PHPSeclib versioning policy

Starting from version 1.1.0 we adopt a flexible versioning policy for
`phpseclib` and specify the dependency as `3.0.*`. This approach allows our
library integrators to quickly incorporate security patches and minor updates
from `phpseclib`.

## Why we include `composer.lock`

While it is common practice for applications to include a `composer.lock` file
to lock down the specific versions of dependencies used, this is less common
for libraries. However, we have chosen to include `composer.lock` in our
repository to clearly indicate the exact versions of dependencies we have
tested against.

Although our library is designed to work with any minor version of `phpseclib`
within the specified range, the `composer.lock` file ensures that integrators
are aware of the specific version we consider stable and secure. The provided
`composer.lock` is intended to be used as a reference, not a strict
requirement.

# Code formatting

We are using `Prettier` for code formatting. To install Prettier, use following command:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
}
},
"require": {
"phpseclib/phpseclib": "3.0.37"
"phpseclib/phpseclib": "3.0.*"
},
"scripts": {
"fix-php": [
Expand Down
Loading

0 comments on commit 37447cd

Please sign in to comment.