Merge up 5.1.2 to 5.2.x #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified TypeScript declaration handling by streamlining the build plugin and removed unnecessary `outDir` config. Upgraded multiple dependencies, including `@simplewebauthn` and Babel-related libraries, for improved functionality and compatibility. Adjusted code for better null/undefined checks in Stimulus controller.
Added a `length="250"` attribute to the `publicKeyCredentialId` field in the doctrine mapping. This enforces a maximum length constraint, ensuring consistency and preventing potential database issues.
Refactored `startAuthentication` and `startRegistration` calls to use object syntax for passing parameters. This improves code clarity and aligns with expected API usage patterns.
Ensure the service throws a clear exception if the required "web-token/jwt-library" package is not installed. This prevents potential runtime issues by guiding users to install the necessary dependency upfront.
Ensure the 'x5c' key contains an array before creating a CertificateTrustPath. This prevents potential errors caused by invalid 'x5c' data structures during denormalization.
The unique constraint on the publicKeyCredentialId field was removed to allow greater flexibility in data handling. This change ensures compatibility with scenarios where the uniqueness of the field is not a strict requirement.
Corrected the typo in the docblock annotation from `@@deprecated` to `@deprecated`. This ensures consistency with standard annotation formatting and improves code readability for developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.