Add origin validation logic and tests for WebAuthn #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
force-pushed
the
features/allowed-origins
branch
from
c5e2e94 to
0029a84
Compare
Introduced `allowed_origins` and `allow_subdomains` as replacements for `secured_rp_ids`, which is now deprecated and planned for removal in 6.0. Updated dependency injection, configuration definitions, and test cases accordingly. Deprecated relevant methods and classes while ensuring backward compatibility.
Spomky
force-pushed
the
features/allowed-origins
branch
from
0029a84 to
520c51b
Compare
This was referenced Feb 16, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
AllowedOriginsControllerandCheckAllowedOriginsclass to handle allowed origin validation for WebAuthn ceremonies. Added functional and unit tests to cover various scenarios, including subdomain handling and empty allowed origins. Updated service configuration for consistency by standardizing$servicevariable usage.Target branch:
Resolves issue #