Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple vectors for a single target #1235

Merged
merged 31 commits into from
Oct 14, 2024
Merged

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Aug 6, 2024

No description provided.

@dirkkul dirkkul requested a review from a team as a code owner August 6, 2024 14:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 88.51351% with 17 lines in your changes missing coverage. Please review.

Project coverage is 94.21%. Comparing base (6234608) to head (0449303).
Report is 95 commits behind head on main.

Files Patch % Lines
weaviate/collections/grpc/query.py 85.48% 9 Missing ⚠️
weaviate/collections/classes/grpc.py 87.09% 4 Missing ⚠️
integration/test_named_vectors.py 92.85% 3 Missing ⚠️
integration/test_collection_hybrid.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   94.42%   94.21%   -0.22%     
==========================================
  Files         215      219       +4     
  Lines       20686    21009     +323     
==========================================
+ Hits        19533    19793     +260     
- Misses       1153     1216      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul changed the base branch from main to dev/1.27 October 8, 2024 14:37
integration/test_collection_hybrid.py Outdated Show resolved Hide resolved
weaviate/collections/grpc/query.py Outdated Show resolved Hide resolved
weaviate/collections/classes/grpc.py Outdated Show resolved Hide resolved
integration/test_named_vectors.py Outdated Show resolved Hide resolved
weaviate/collections/grpc/query.py Show resolved Hide resolved
weaviate/collections/grpc/query.py Outdated Show resolved Hide resolved
weaviate/collections/grpc/query.py Outdated Show resolved Hide resolved
@dirkkul dirkkul merged commit b30e8f4 into dev/1.27 Oct 14, 2024
49 of 51 checks passed
@dirkkul dirkkul deleted the multi_vector_same_target branch October 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants