-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add KubeAI model provider integration #2553
base: main
Are you sure you want to change the base?
Conversation
d2a6aa2
to
6a38738
Compare
6a38738
to
93940fb
Compare
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Agree |
Could I get a review please? @databyjp Please just let me know directly if you prefer not to merge this. I can close this PR, np at all. |
Hey @samos123, thank you for this and sorry about the delay. We do want to move forward with this in some way. We have been just internally discussing how to best do it. It may not be ideal to ask users to pass on dummy API keys and so on, so we are internally discussing what to do from our module perspective, perhaps to create one for "openai-compatible" APIs. |
I think the UX of re-using existing modules would be better. Not having to enable new modules and out of the box compatibility with all existing Weaviate versions. Note that right now KubeAI ignores the API key field, but this may change in the future. The plan is to allow users to configure an API key. So I wouldn't use configuring "dummy API keys" as a reason for having a separate module. I'm fine with whatever the Weaviate team thinks is the best path forward. Just sharing my pov in case it's helpful. Happy to join any discussions as well. |
Thanks Sam. Yeah, I do see some of those points. From my perspective, we are looking at framing things a little more user-centrically. So, we've added:
I personally worry about coupling many of these keys and features around one module and client methods, which would make them difficult to untangle in case of changes. As an example, it would be easier to have the python docstring clearly point to a generic "OpenAI-compatible" API docs that people can build around, vs an actual OpenAI module. We have actually separated the I do appreciate that it's probably not a slam dunk easy decision one way or another for now, but this is the way we are looking at it currently. |
Hey @samos123 - what do you think about this: We could go ahead with some version of this PR for now, with the proviso that the actual code will be swapped out at some time with an Edit: This way we are not holding you back while we figure out what to do at our end 😄 |
Yeah that works for me. I would be happy to collaborate and test the new module as well. Feel free to make any modifications to this PR directly as well. |
What's being changed:
Add KubeAI as a model provider to https://weaviate.io/developers/weaviate/model-providers
Type of change:
How Has This Been Tested?
yarn start
I tested this using steps documented here: https://github.com/substratusai/kubeai/blob/main/docs/tutorials/weaviate.md