Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning Centre - JPH proposed edits #2487

Closed
wants to merge 1 commit into from

Conversation

databyjp
Copy link
Contributor

@databyjp databyjp commented Aug 23, 2024

What's being changed:

Proposed edits to the draft "Learning Centre" section

  • Remove the "Resources" section and move the section links to the Header element.

    • Have not deleted the React component; should delete if we decide to go with this
  • Formatting for repo names to use <code>

  • Removed links on the bottom on cards where there isn't one appropriate link.

    • With the idea that each <li> item would become a link
    • If agreed, we (JP/docs) can add links
  • Copyedits

  • Outstanding:

    • Example repos need to be added (unsure what)
    • The "Go Further" cards need padding underneath when browser width very narrow. They stack on top of each other as a 2x2 without any spacing

Type of change:

  • Documentation updates (non-breaking change to fix/update documentation)
  • Website updates (non-breaking change to update main page, company pages, pricing, etc)

How Has This Been Tested?

  • GitHub action – automated build completed without errors
  • Local build - the site works as expected when running yarn start

note, you can run yarn verify-links to test site links locally

@databyjp databyjp changed the title JPH proposed edits Learning Centre - JPH proposed edits Aug 23, 2024
@databyjp databyjp closed this Oct 10, 2024
@databyjp databyjp deleted the learning-zone-jph-comments-202408 branch October 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant