Propose moving to node v20.12.2 in docs due to errors when testing #2005
Conversation
| `weaviate.io` project dependencies. | ||
|
|
||
| ``` | ||
| nvm install node 19.9.0 | ||
| nvm use 19.9.0 | ||
| nvm install 20.12.2 |
There was a problem hiding this comment.
Previous behavior
nvm install node 19.9.0
v22.0.0 is already installed.New behavior:
nvm install 20.12.2
v20.12.2 is already installed.note
nvm --version
0.39.5| nvm install node 19.9.0 | ||
| nvm use 19.9.0 | ||
| nvm install 20.12.2 | ||
| nvm use 20.12.2 |
There was a problem hiding this comment.
Using node v19.9.0, got:
nvm use 19.9.0
yarn install
yarn install v1.22.22
[1/5] 🔍 Validating package.json...
[2/5] 🔍 Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "eta@^2.0.0"
warning Resolution field "[email protected]" is incompatible with requested version "eta@^2.0.0"
warning Resolution field "[email protected]" is incompatible with requested version "eta@^2.0.0"
[3/5] 🚚 Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18 || >=20". Got "19.9.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
|
@databyjp I think @nathanwilk7 is running into the same thing I did when I set up locally. Our tool chain is aging and we're starting to hit compatibility problems. Let's talk to @sebawita about updating. I think you two have a better idea about what's involved. |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
|
Ugh, sorry this slipped through the cracks. Noticed this while creating the PR #2764 - I will close this as a duplicate. Sorry about that @nathanwilk7 😓 that's my bad. FWIW the GH action shows as node 20, and I've been running 20 locally without additional issues. So hopefully everything is up to date. |
What's being changed:
Propose moving to suggesting node
v20.12.2because of a package error when running onv19.9.0just now (on an arm64 macbook).Also removes
nodefromnvm install node 19.9.0becausenvmwas ignoring the version when I ran this.Type of change:
How Has This Been Tested?
yarn startRan
yarn buildlocally