Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadBalancerIp configuration for HTTP and GPRS services #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions weaviate/templates/weaviateService.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ spec:
{{ end }}
{{ end }}
{{ if eq .Values.service.type "LoadBalancer" -}}
{{ if .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{ end }}
Comment on lines +26 to +28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "-" to if and end statements like so:

{{- if condition }}
...
{{- end }}

{{- if gt (len .Values.service.loadBalancerSourceRanges) 0 }}
loadBalancerSourceRanges:
{{- range $_, $sourceRange := .Values.service.loadBalancerSourceRanges }}
Expand Down
3 changes: 3 additions & 0 deletions weaviate/templates/weaviateServiceGRPC.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ spec:
{{ end }}
{{ end }}
{{ if eq .Values.grpcService.type "LoadBalancer" -}}
{{ if .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{ end }}
Comment on lines +27 to +29
Copy link
Collaborator

@antas-marcin antas-marcin Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be Values.grpcService not Values.service and can you add "-" to if and end statements like so:

{{- if condition }}
...
{{- end }}

{{- if gt (len .Values.grpcService.loadBalancerSourceRanges) 0 }}
loadBalancerSourceRanges:
{{- range $_, $sourceRange := .Values.grpcService.loadBalancerSourceRanges }}
Expand Down
Loading