Add option to specify labels for service #199
Conversation
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
|
If you want us to merge your PR you need to agree to our CLA. Simply making a |
| {{- with .Values.service.labels }} | ||
| {{ toYaml . | indent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Can you add tests for this? You can use check_string_existence method for that
| {{- with .Values.service.labels }} | ||
| {{ toYaml . | indent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Can you also add a separate test for this case?
|
I agree with CLA |
|
We actually ended up going with another vector database. So my attention has moved on from here and I won't be pushing this forward. But i've got "Allow edits by maintainers" checked and will happily give anyone else that wants to finish this contributor access. Also feel free to just close. No feelings hurt here. 🙏 |
As part of being able to auto discover weaviate in cluster being able to append labels to the service helps a lot