Add election and snapshot configurations as optional parameters #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use BootstrapExpect to specify the number of voters
Comment on lines
+234
to
+239
| # RAFT_HEARTBEAT_TIMEOUT: 1 | ||
| # RAFT_ELECTION_TIMEOUT: 1 | ||
| # Control how often raft checks if it should perform a snapshot | ||
| # RAFT_SNAPSHOT_INTERVAL: 120 | ||
| # Number of outstanding log entries before performing a snapshot | ||
| # RAFT_SNAPSHOT_THRESHOLD: 8192 |
There was a problem hiding this comment.
Red, can you make appropriate comments on each env variable describing what it does and what's the default value?
We have a rule that we try to make descriptive comments on each env variable so that the user would know what a given setting does
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
jfrancoa
force-pushed
the
raft-configuration
branch
from
76f31af
to
a159f6a
Compare
jfrancoa
force-pushed
the
raft-configuration
branch
2 times, most recently
from
969d6c5
to
f8a8526
Compare
antas-marcin
force-pushed
the
raft-configuration
branch
3 times, most recently
from
f41f161
to
ba8d329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.