Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart now using existing pvc #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

franciscouribe
Copy link

@franciscouribe franciscouribe commented Oct 28, 2023

Fixed this issue https://forum.weaviate.io/t/cannot-bind-to-existing-pvc/598/2

The docs in values.yaml state:

# The Persistent Volume Claim settings for Weaviate. If there's a
# storage.fullnameOverride field set, then the default pvc will not be
# created, instead the one defined in fullnameOverride will be used

However, the current Helm Chart implementation is not using storage.fullnameOverride at all.

Now the chart is using storage.fullnameOverride when available and therefore is behaving according to the docs.

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@kmichailg
Copy link

+1

Ran into this issue today. Template is not picking up the PVC I deployed prior to deploying the template.

# The Persistent Volume Claim settings for Weaviate. If there's a
# storage.fullnameOverride field set, then the default pvc will not be
# created, instead the one defined in fullnameOverride will be used
storage:
  fullnameOverride: my-pv-claim
  # size: 32Gi
  # storageClassName: ""

@antas-marcin
Copy link
Collaborator

@franciscouribe can you rebase your PR with the lastest master changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants