Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon and status for tf plans that are waiting for user action #3658

Merged
merged 4 commits into from
May 3, 2023

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Apr 28, 2023

Closes weaveworks/weave-gitops-enterprise#2745

Adds case for terraform folks to know when they have to take an action on their plan. Preview of what icon looks like below:
image

@joshri joshri added the area/ui Issues that require front-end work label Apr 28, 2023
@joshri joshri requested a review from chanwit April 28, 2023 13:34
Copy link
Member

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joshri
The change to the readCompute function makes sense to me.

There is an empty block which causes a lint error btw.

Comment on lines 48 to 49
{
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
}

@joshri joshri force-pushed the pending-action-icon branch from c348788 to 97be700 Compare May 1, 2023 20:43
@joshri joshri marked this pull request as ready for review May 2, 2023 13:06
@joshri joshri requested a review from opudrovs May 2, 2023 13:06
@joshri joshri force-pushed the pending-action-icon branch from 97be700 to 26c384e Compare May 2, 2023 21:03
@chanwit
Copy link
Member

chanwit commented May 3, 2023

Orange icon! approved!
image

@chanwit chanwit self-requested a review May 3, 2023 11:17
Copy link
Member

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opudrovs
Copy link
Contributor

opudrovs commented May 3, 2023

Cool, thank you for testing it, @chanwit !

@joshri joshri force-pushed the pending-action-icon branch from 26c384e to fd0afbb Compare May 3, 2023 12:42
@joshri joshri merged commit 2ab6561 into main May 3, 2023
@joshri joshri deleted the pending-action-icon branch May 3, 2023 13:02
This was referenced May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Terraform Change Terraform Icon when waiting for a Plan
3 participants