-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon and status for tf plans that are waiting for user action #3658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joshri
The change to the readCompute function makes sense to me.
There is an empty block which causes a lint error btw.
{ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
} |
c348788
to
97be700
Compare
97be700
to
26c384e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool, thank you for testing it, @chanwit ! |
26c384e
to
fd0afbb
Compare
Closes weaveworks/weave-gitops-enterprise#2745
Adds case for terraform folks to know when they have to take an action on their plan. Preview of what icon looks like below:
