Helm upgrades #1779
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| apiVersion: v2 | ||
| name: weave-gitops | ||
| description: Weave Gitops is a set of tools and services to aid your interactions with Flux | ||
|
|
||
| # A chart can be either an 'application' or a 'library' chart. | ||
| # | ||
| # Application charts are a collection of templates that can be packaged into versioned archives | ||
| # to be deployed. | ||
| # | ||
| # Library charts provide useful utilities or functions for the chart developer. They're included as | ||
| # a dependency of application charts to inject those utilities and functions into the rendering | ||
| # pipeline. Library charts do not define any templates and therefore cannot be deployed. | ||
| type: application | ||
|
|
||
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 1.1.0 | ||
|
|
||
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "v0.6.2" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Weave Gitops Helm Chart | ||
|
|
||
| This is the [Weave Gitops](https://github.com/weaveworks/weave-gitops) [Helm](https://helm.sh) chart. | ||
|
|
||
| It installs the weave-gitops-server component as a 1-replica deployment. | ||
|
|
||
| Optionally it will also install: | ||
| * Service Account | ||
| * ClusterRoleBinding (to the service account) and ClusterRole with the | ||
| permissions required to run Gitops. | ||
| * Service, this is optional as you may want to limit access to the UI to via | ||
| port-forwarding | ||
| * Ingress | ||
| * Test User -- A test user with hard-coded username & password with minimal | ||
| permissions | ||
|
|
||
| This chart assumes kubernetes > 1.17 | ||
|
|
||
| ## Security | ||
|
|
||
| The role that this chart creates includes 2 main 'blocks' of permissions; that | ||
| should be treated separately and carefully: | ||
|
|
||
| * `impersonate` This is how the gitops-server gathers data to display in the UI, | ||
| it impersonates the user, determined by OIDC/plain auth. This means that | ||
| a user's permissions in the UI will reflect their permissions in the cluster | ||
| * `get`, `list`, `watch` on `helmrepositories` and `secrets`. These permissions | ||
| are required by the profiles system. | ||
|
|
||
| ### Impersonate | ||
|
|
||
| When deploying gitops-server it is recommended to limit the types of resource | ||
| and specific resources that the service account can impersonate. e.g. | ||
| ```yaml | ||
| rbac: | ||
| create: true | ||
|
There was a problem hiding this comment. It is not like users have a choice here, they must have impersonation setup otherwise nothing works. So ideally we could have some default values as There was a problem hiding this comment. I've improved how the defaults for Much as I'd love to provide defaults for There was a problem hiding this comment. definitely, we can't set anything there since there is no way for us to know what groups the companies use. I'm good with that, the important bit that's allowing configuration is there, it should be enough. |
||
| impersonationResources: ["groups"] | ||
| impersonationResourceNames: ["gitops-reader"] | ||
| ``` | ||
|
|
||
| Using groups is the recommended way of doing this as it means that you don't | ||
| have to enumerate all users in a group. | ||
|
|
||
| ### Get helmrepositories | ||
|
|
||
| This permissions are scoped to enable the profiles functionality of gitops-server | ||
| and should not need to change. | ||
|
|
||
| ### Test User | ||
|
|
||
| This user should not be used, it is intended for development and testing | ||
| purposes and relies on static credentials in a secret. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| 1. Get the application URL by running these commands: | ||
| {{- if .Values.ingress.enabled }} | ||
| {{- range $host := .Values.ingress.hosts }} | ||
| {{- range .paths }} | ||
| http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $host.host }}{{ .path }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- else if contains "NodePort" .Values.service.type }} | ||
| export NODE_PORT=$(kubectl get --namespace {{ .Release.Namespace }} -o jsonpath="{.spec.ports[0].nodePort}" services {{ include "chart.fullname" . }}) | ||
| export NODE_IP=$(kubectl get nodes --namespace {{ .Release.Namespace }} -o jsonpath="{.items[0].status.addresses[0].address}") | ||
| echo http://$NODE_IP:$NODE_PORT | ||
| {{- else if contains "LoadBalancer" .Values.service.type }} | ||
| NOTE: It may take a few minutes for the LoadBalancer IP to be available. | ||
| You can watch the status of by running 'kubectl get --namespace {{ .Release.Namespace }} svc -w {{ include "chart.fullname" . }}' | ||
| export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ include "chart.fullname" . }} --template "{{"{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}"}}") | ||
| echo http://$SERVICE_IP:{{ .Values.service.port }} | ||
| {{- else if contains "ClusterIP" .Values.service.type }} | ||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "chart.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}") | ||
| export CONTAINER_PORT=$(kubectl get pod --namespace {{ .Release.Namespace }} $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") | ||
| echo "Visit http://127.0.0.1:8080 to use your application" | ||
| kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 8080:$CONTAINER_PORT | ||
| {{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| {{/* | ||
| Expand the name of the chart. | ||
| */}} | ||
| {{- define "chart.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| If release name contains chart name it will be used as a full name. | ||
| */}} | ||
| {{- define "chart.fullname" -}} | ||
| {{- if .Values.fullnameOverride }} | ||
| {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- $name := default .Chart.Name .Values.nameOverride }} | ||
| {{- if contains $name .Release.Name }} | ||
| {{- .Release.Name | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create chart name and version as used by the chart label. | ||
| */}} | ||
| {{- define "chart.chart" -}} | ||
| {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Common labels | ||
| */}} | ||
| {{- define "chart.labels" -}} | ||
| helm.sh/chart: {{ include "chart.chart" . }} | ||
| {{ include "chart.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Selector labels | ||
| */}} | ||
| {{- define "chart.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "chart.name" . }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create the name of the service account to use | ||
| */}} | ||
| {{- define "chart.serviceAccountName" -}} | ||
| {{- if .Values.serviceAccount.create }} | ||
| {{- default (include "chart.fullname" .) .Values.serviceAccount.name }} | ||
| {{- else }} | ||
| {{- default "default" .Values.serviceAccount.name }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Return the target Kubernetes version | ||
| */}} | ||
| {{- define "common.capabilities.kubeVersion" -}} | ||
| {{- if .Values.global }} | ||
| {{- if .Values.global.kubeVersion }} | ||
| {{- .Values.global.kubeVersion -}} | ||
| {{- else }} | ||
| {{- default .Capabilities.KubeVersion.Version .Values.kubeVersion -}} | ||
| {{- end -}} | ||
| {{- else }} | ||
| {{- default .Capabilities.KubeVersion.Version .Values.kubeVersion -}} | ||
| {{- end -}} | ||
| {{- end -}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| {{- if .Values.adminUser.create }} | ||
| # This should not be used in production. It is for testing & demo purposes only | ||
| # FIXME issues #1789, #1787, #1671 | ||
| # the contents of this file are dependent upon the outcome of several | ||
| # discussions around usage of the admin user. Once those are resolved the | ||
| # configuration here should be brought into line with those outcomes (e.g. | ||
| # names(paces) made configurable, permissions set). | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: wego-test-user-read-resources | ||
| namespace: flux-system | ||
| subjects: | ||
| - kind: User | ||
| name: wego-admin | ||
| namespace: {{ .Release.Namespace }} | ||
| roleRef: | ||
| kind: Role | ||
| name: wego-admin-role | ||
| apiGroup: rbac.authorization.k8s.io | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| name: wego-admin-role | ||
| namespace: flux-system | ||
| rules: | ||
| - apiGroups: [""] | ||
| resources: ["secrets", "pods" ] | ||
| verbs: [ "get", "list" ] | ||
| - apiGroups: ["apps"] | ||
| resources: [ "deployments", "replicasets", "pods" ] | ||
| verbs: [ "get", "list" ] | ||
| - apiGroups: ["kustomize.toolkit.fluxcd.io"] | ||
| resources: [ "kustomizations" ] | ||
| verbs: [ "get", "list" ] | ||
| - apiGroups: ["helm.toolkit.fluxcd.io"] | ||
| resources: [ "helmreleases" ] | ||
| verbs: [ "get", "list" ] | ||
| - apiGroups: ["source.toolkit.fluxcd.io"] | ||
| resources: [ "buckets", "helmcharts", "gitrepositories", "helmrepositories" ] | ||
| verbs: [ "get", "list" ] | ||
| - apiGroups: [""] | ||
| resources: ["events"] | ||
| verbs: ["get", "watch", "list"] | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: cluster-user-auth | ||
| namespace: flux-system | ||
| type: Opaque | ||
| data: | ||
| {{- with .Values.adminUser }} | ||
| username: {{ .username | b64enc | quote }} | ||
| {{/* | ||
| htpasswd returns user-file format, e.g. 'username:passwordhash' so as well | ||
| as using htpasswd to generate the bcrypt hash we also need to extract the | ||
| final element before base64 enconding it for k8s (and quoting it b/c yaml) | ||
| */}} | ||
| {{- $bcryptPasswordHash := .password | required "You must set a password for this user!" | htpasswd "" }} | ||
| password: {{ regexSplit ":" $bcryptPasswordHash -1 | last | b64enc | quote }} | ||
| {{- end }} | ||
| {{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: {{ include "chart.fullname" . }} | ||
| labels: | ||
| {{- include "chart.labels" . | nindent 4 }} | ||
| spec: | ||
| replicas: {{ .Values.replicaCount }} | ||
| selector: | ||
| matchLabels: | ||
| {{- include "chart.selectorLabels" . | nindent 6 }} | ||
| template: | ||
| metadata: | ||
| {{- with .Values.podAnnotations }} | ||
| annotations: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| labels: | ||
| {{- include "chart.selectorLabels" . | nindent 8 }} | ||
| spec: | ||
| {{- with .Values.imagePullSecrets }} | ||
| imagePullSecrets: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| serviceAccountName: {{ include "chart.serviceAccountName" . }} | ||
| securityContext: | ||
| {{- toYaml .Values.podSecurityContext | nindent 8 }} | ||
| containers: | ||
| - name: {{ .Chart.Name }} | ||
| securityContext: | ||
| {{- toYaml .Values.securityContext | nindent 12 }} | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | ||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| args: | ||
| - "--helm-repo-namespace" | ||
| - "{{ .Release.Namespace }}" | ||
| - "--log-level" | ||
| - "{{ .Values.logLevel }}" | ||
| {{- with .Values.additionalArgs }} | ||
| {{- range . }} | ||
| - {{ . | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| ports: | ||
| - name: http | ||
| containerPort: 9001 | ||
| protocol: TCP | ||
| livenessProbe: | ||
| httpGet: | ||
| path: / | ||
| port: http | ||
| readinessProbe: | ||
| httpGet: | ||
| path: / | ||
| port: http | ||
| {{- if or .Values.enableLogin .Values.envVars}} | ||
| env: | ||
| {{- if .Values.enableLogin }} | ||
| - name: WEAVE_GITOPS_AUTH_ENABLED | ||
| value: "true" | ||
| {{- end }} | ||
| {{- with .Values.envVars }} | ||
| {{- toYaml . | nindent 12 }} | ||
| {{- end }} | ||
| {{- end }} | ||
| resources: | ||
| {{- toYaml .Values.resources | nindent 12 }} | ||
| {{- with .Values.nodeSelector }} | ||
| nodeSelector: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.affinity }} | ||
| affinity: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.tolerations }} | ||
| tolerations: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| {{- if .Values.ingress.enabled -}} | ||
| {{- $fullName := include "chart.fullname" . -}} | ||
| {{- $svcPort := .Values.service.port -}} | ||
| {{- if and .Values.ingress.className (not (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion)) }} | ||
| {{- if not (hasKey .Values.ingress.annotations "kubernetes.io/ingress.class") }} | ||
| {{- $_ := set .Values.ingress.annotations "kubernetes.io/ingress.class" .Values.ingress.className}} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}} | ||
| apiVersion: networking.k8s.io/v1 | ||
| {{- else if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} | ||
| apiVersion: networking.k8s.io/v1beta1 | ||
| {{- else -}} | ||
| apiVersion: extensions/v1beta1 | ||
| {{- end }} | ||
| kind: Ingress | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| labels: | ||
| {{- include "chart.labels" . | nindent 4 }} | ||
| {{- with .Values.ingress.annotations }} | ||
| annotations: | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} | ||
| spec: | ||
| {{- if and .Values.ingress.className (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion) }} | ||
| ingressClassName: {{ .Values.ingress.className }} | ||
| {{- end }} | ||
| {{- if .Values.ingress.tls }} | ||
| tls: | ||
| {{- range .Values.ingress.tls }} | ||
| - hosts: | ||
| {{- range .hosts }} | ||
| - {{ . | quote }} | ||
| {{- end }} | ||
| secretName: {{ .secretName }} | ||
| {{- end }} | ||
| {{- end }} | ||
| rules: | ||
| {{- range .Values.ingress.hosts }} | ||
| - host: {{ .host | quote }} | ||
| http: | ||
| paths: | ||
| {{- range .paths }} | ||
| - path: {{ .path }} | ||
| {{- if and .pathType (semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion) }} | ||
| pathType: {{ .pathType }} | ||
| {{- end }} | ||
| backend: | ||
| {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }} | ||
| service: | ||
| name: {{ $fullName }} | ||
| port: | ||
| number: {{ $svcPort }} | ||
| {{- else }} | ||
| serviceName: {{ $fullName }} | ||
| servicePort: {{ $svcPort }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test user is actually a backup admin user in the case that OIDC is failing and cluster ops need to do things.
It is currently undergoing some feature realignment, see the thread here: https://weaveworks.slack.com/archives/C03244W0C8H/p1647967858091769
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you have a backup admin with only read permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because those are all i added so far 🙃 , probably because that is all wego core can do right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from a point of least privilige I'd like to only make it a requirement/recommendation when it's actually in a position to fulfill those extended duties ;)