Static Users #1755
Closed
Static Users #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @yiannistri |
Callisto13
reviewed
Mar 22, 2022
| if loginRequest.Username != string(hashedSecret.Data["username"]) { | ||
| s.Log.Info("Wrong username") | ||
| rw.WriteHeader(http.StatusUnauthorized) | ||
| if err := s.kubernetesClient.List(r.Context(), users, opts...); err != nil { |
There was a problem hiding this comment.
do we need to list all users, or can we just get a specific one based on the username?
There was a problem hiding this comment.
we can't query based on any data value. So to accomplish that we would need to force users to use some kind of convention for names, but that would still be tricky because they can choose to use an email address as the username and that's not a valid name for a k8s resource.
Listing isn't ideal but at least we only list the secrets with that particular Label. And in practice, there should be a small number of those.
jpellizzari
approved these changes
Mar 22, 2022
|
This may be being rolled back, see: https://weaveworks.slack.com/archives/C03244W0C8H/p1647967858091769 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1598 #1722
What changed?
The concept of Static User has been introduced. This feature allows operators to create an undefined number of Users by creating K8s Secrets with a well-defined structure and label so that Weave Gitops can query and match credentials.
Why?
How did you test it?
Release notes
*Documentation Changes