Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all the (UI) things #2321

Open
jpellizzari opened this issue Jun 14, 2022 · 5 comments
Open

Export all the (UI) things #2321

jpellizzari opened this issue Jun 14, 2022 · 5 comments
Assignees
Labels
area/ui Issues that require front-end work type/story

Comments

@jpellizzari
Copy link
Contributor

We currently maintain an index.ts file that describes all the things that the weave-gitops NPM module exports. Instead of maintaining this, we should just export everything. We already consume go packages from -core without any manual exports defined, so this will align with that.

Some historical context: we had originally intended to export only the ENTIRE core app and have it called into the EE app; instead the EE team decided to import individual components (this made routing, etc easier).

@jpellizzari jpellizzari self-assigned this Jun 14, 2022
@jpellizzari
Copy link
Contributor Author

Gave up on this for now. I tried getting rid of individual exports, but gave up due to not having very good control of the build system in EE. It is still "unejected" create-react-app, and is giving error messages that don't leave breadcrumbs.

Here is the work I did: https://github.com/weaveworks/weave-gitops/tree/2321-js-exports

Selfishly, I also didn't want to sign on to update all the exports in the EE repo (at least right now)

Module is here: https://github.com/weaveworks/weave-gitops/packages/945027

@sympatheticmoose
Copy link
Contributor

@jpellizzari is this still valid?

@jpellizzari
Copy link
Contributor Author

Yes still valid and useful

@lasomethingsomething
Copy link
Contributor

@jpellizzari Same question as before, but 10 months later :)

@lasomethingsomething lasomethingsomething added the area/ui Issues that require front-end work label Sep 1, 2023
@jpellizzari
Copy link
Contributor Author

jpellizzari commented Sep 1, 2023

@jpellizzari Same question as before, but 10 months later :)

Same answer unfortunately 😢

But progress is being made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work type/story
Projects
None yet
Development

No branches or pull requests

3 participants