-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export all the (UI) things #2321
Comments
Gave up on this for now. I tried getting rid of individual exports, but gave up due to not having very good control of the build system in EE. It is still "unejected" create-react-app, and is giving error messages that don't leave breadcrumbs. Here is the work I did: https://github.com/weaveworks/weave-gitops/tree/2321-js-exports Selfishly, I also didn't want to sign on to update all the exports in the EE repo (at least right now) Module is here: https://github.com/weaveworks/weave-gitops/packages/945027 |
@jpellizzari is this still valid? |
Yes still valid and useful |
@jpellizzari Same question as before, but 10 months later :) |
Same answer unfortunately 😢 But progress is being made! |
We currently maintain an
index.ts
file that describes all the things that theweave-gitops
NPM module exports. Instead of maintaining this, we should just export everything. We already consumego
packages from-core
without any manual exports defined, so this will align with that.Some historical context: we had originally intended to export only the ENTIRE core app and have it called into the EE app; instead the EE team decided to import individual components (this made routing, etc easier).
The text was updated successfully, but these errors were encountered: