Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EE Rename ui-cra -> ui and move package.json to root #3250

Closed
foot opened this issue Aug 25, 2023 · 5 comments · Fixed by #3263
Closed

EE Rename ui-cra -> ui and move package.json to root #3250

foot opened this issue Aug 25, 2023 · 5 comments · Fixed by #3263
Assignees
@foot
Labels
area/ui team/pesto ui_triage Cross-team/project UI issues for triage

Comments

@foot
Copy link
Collaborator

foot commented Aug 25, 2023

Follow OSS lead here.

Why?

  • cd ui-cra before having to run yarn start is a little bit annoying

Concerns:

  • any inflight PRs are gonna have a bad time w/ conflict resolutions
@foot foot added the ui_triage Cross-team/project UI issues for triage label Aug 25, 2023
@bigkevmcd
Copy link
Contributor

I think the conflict resolution should be ok?

@foot
Copy link
Collaborator Author

foot commented Aug 25, 2023

I think the conflict resolution should be ok?

Good point might be fine. git can handle renames pretty well sometimes?

@bigkevmcd
Copy link
Contributor

I'm pretty sure it'll be ok, unless the PR does something "odd".

@jpellizzari
Copy link
Contributor

jpellizzari commented Aug 29, 2023 •
edited
Loading

Note: CI jobs/Make targets might be pointing at the subdirectory for running FE scripts

@foot foot mentioned this issue Aug 29, 2023
Merged
@jpellizzari jpellizzari mentioned this issue Sep 1, 2023
Open
@lasomethingsomething
Copy link

Makes progress on weaveworks/weave-gitops#2321 per @jpellizzari (I removed the link to this private issue on the public repo and connect here for our internal reference)

@foot foot added the team/pesto label Sep 5, 2023
@foot foot closed this as completed in #3263 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foot foot

Labels
area/ui team/pesto ui_triage Cross-team/project UI issues for triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ui-cra -> ui and move package.json to root weaveworks/weave-gitops-enterprise
4 participants
@foot @bigkevmcd @lasomethingsomething @jpellizzari