Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional latency metrics to query service #3730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpellizzari
Copy link

Adding some additoinal metrics to the query service. This will allow us to see which operations take a long time. If query service takes a long time, but indexer/store are fast, then there is something withing the RunQuery body taking too long.

@jpellizzari jpellizzari added the exclude from release notes Use this label to exclude a PR from the release notes label Dec 14, 2023
@jpellizzari jpellizzari marked this pull request as ready for review December 14, 2023 20:01
Adding some additoinal metrics to the query service. This will allow us to see which operations take a long time. If query service takes a long time, but indexer/store are fast, then there is something withing the RunQuery body taking too long.
Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you consider using https://docs.gitops.weave.works/docs/explorer/operations/#api-server ?

it feels that should provide similar information given

func (s *server) DoQuery(ctx context.Context, msg *pb.DoQueryRequest) (*pb.DoQueryResponse, error) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants