Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up /template APIs #3646

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Tidy up /template APIs #3646

wants to merge 12 commits into from

Conversation

foot
Copy link
Collaborator

@foot foot commented Nov 17, 2023

What changed?

Tidy up the templates APIs

  • Remove /profiles and /params endpoints, they just return a post-filtered subset of /templates/{name} and are not used by the UI
  • Align preview and create-pull-request endpoints, they had differing param names
    • createpullrequest.values -> profiles (aligned w/ preview.profiles)
    • preview.values -> parameter_values (aligned w/ createpullrequest.parameter_values)

Small fix to secrets param in the path:

  • external_secret_name -> name

- `default` looks a bit more consistent for now
- Remove /profiles and /params endpoints
- They just return a post-filtered subset of /templates/{name}
- Align preview and create-pull-request endpoints, they had differing
  param names
- createpullrequest.values -> profiles (aligned w/ preview.profiles)
- preview.values -> parameter_values (aligned w/
  createpullrequest.parameter_values)
- Hopefully we can just use the OSS one
Also external_secret_name -> name
@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Dec 4, 2023
@foot foot marked this pull request as ready for review December 4, 2023 19:28
@foot foot requested a review from AlinaGoaga December 4, 2023 19:32
Copy link
Contributor

@AlinaGoaga AlinaGoaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 🥳 Unrelated to the changes in this PR (already on https://demo-01.eng-sandbox.weave.works/) I've noticed that when you click PR Preview in Secret Creation, if there are missing params, it doesn't flag the missing field (there's no feedback to the user). The other sections seem ok. Will log a ticket for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants