Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoToOpenPullReqesut button to be button Group to include the Multi Repos #2566

Merged
merged 26 commits into from
Apr 6, 2023

Conversation

ahussein3
Copy link
Contributor

@ahussein3 ahussein3 commented Mar 19, 2023

Closes #2466

What changed?

Why was this change made?

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@ahussein3 ahussein3 added the enhancement New feature or request label Mar 19, 2023
@ahussein3 ahussein3 marked this pull request as ready for review March 20, 2023 10:22
@foot
Copy link
Collaborator

foot commented Mar 28, 2023

Now the BE returns:

{
  "repositoryURL": "https://gitlab.git.dev.weave.works/wge/demo-01",
  "managementClusterName": "management",
  "uiConfig": "{\"footer\":{\"backgroundColor\":\"\",\"color\":\"\",\"content\":\"\",\"hideVersion\":false},\"logoURL\":\"\"}",
  "gitHostTypes": {
    "dev.azure.com": "azure-devops",
    "github.com": "github",
    "gitlab.com": "gitlab",
    "gitlab.git.dev.weave.works": "gitlab",
    "ssh.dev.azure.com": "azure-devops"
  }
}

So we need to

  1. Get the domain from any GitRepo.spec.url
  2. use the config.gitHostType to get the provider
  3. From the provider construct a URL for
  4. The "view pull requests"
  5. The "create PR (?)" url?

@foot
Copy link
Collaborator

foot commented Apr 6, 2023

  • Make button text uppercase
  • Put icon back

@ahussein3 ahussein3 requested a review from foot April 6, 2023 12:38
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ahussein3 ahussein3 merged commit f84d5b2 into main Apr 6, 2023
@ahussein3 ahussein3 deleted the UI-2466-AddBtnGrouptoOpenPull branch April 6, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Update the "View Pull Requests" to support multi-repo
2 participants