Skip to content

Commit

Permalink
Merge pull request #3303 from weaveworks/jp-ts-project-settings
Browse files Browse the repository at this point in the history
Fix some typescript project settings affecting local dev
  • Loading branch information
jpellizzari authored Sep 7, 2023
2 parents 177d822 + 9877295 commit 67b92ec
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,15 @@ ui-build: node_modules $(shell find ui/src -type f)

# This job assumes that the weave-gitops repo located next to this repo in the filesystem
core-ui:
cd ../../weave-gitops && \
cd ../weave-gitops && \
npm run build:lib && \
npm run typedefs && \
cd ../weave-gitops-enterprise

core-lib:
rm -rf node_modules/@weaveworks/weave-gitops/
rm -rf .parcel-cache/
yarn add ../../weave-gitops/dist
yarn add ../weave-gitops/dist

ui-audit:
# Check js packages for any high or critical vulnerabilities
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"jsx": "react-jsx"
},
"include": [
"src"
"ui"
]
}
6 changes: 3 additions & 3 deletions ui/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import {
AppContextProvider,
AuthCheck,
AuthContextProvider,
coreClient,
CoreClientContextProvider,
LinkResolverProvider,
Pendo,
SignIn,
ThemeTypes,
coreClient,
theme,
ThemeTypes,
} from '@weaveworks/weave-gitops';
import React, { ReactNode } from 'react';
import {
Expand All @@ -24,7 +24,7 @@ import {
import { BrowserRouter, Route, Switch } from 'react-router-dom';
import { ToastContainer } from 'react-toastify';
import 'react-toastify/dist/ReactToastify.css';
import { ThemeProvider, createGlobalStyle } from 'styled-components';
import { createGlobalStyle, ThemeProvider } from 'styled-components';
import { Pipelines } from './api/pipelines/pipelines.pb';
import { Query } from './api/query/query.pb';
import { Terraform } from './api/terraform/terraform.pb';
Expand Down
6 changes: 6 additions & 0 deletions ui/src/svg.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
declare module '*.svg' {
import React = require('react');
export const ReactComponent: React.ElementType<React.SVGProps>;
const src: string;
export default src;
}

0 comments on commit 67b92ec

Please sign in to comment.