This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Robust recursive FileWatcher support using notify
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary support for moving/renaming, doesn't work yet.
# Conflicts: # go.mod
luxas
added
the
kind/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This achieves what #258 was supposed to. After experimentation we found out that https://github.com/rjeczalik/notify natively supports recursive watches with
inotifyin a much more robust way than having external directory handler implementations.The benchmark here completed with 100000 files in 100 subdirectories without any missed events on my machine, so
notifyseems to be the most robust solution for now.