Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sort and custom queries (instead of using QueryParser) #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

casperc
Copy link

@casperc casperc commented Jul 26, 2013

This commit introduces two new features:

  1. It is possible to pass a sort to the search function to have the output sorted. A utility function for creating the most common sorts is provided but it is also possible to create a sort manually and pass it to search.

  2. It is possible to pass the search function an instantiated query rather than a string to bypass the query parser. Passing a string works as expected.

1) It is possible to pass a sort to the search function to have the output sorted. A utility function for creating the most common sorts is provided but it is also possible to create a sort manually and pass it to search.

2) It is possible to pass the search function an instantiated query rather than a string to bypass the query parser. Passing a string works as expected.
@casperc
Copy link
Author

casperc commented Jul 26, 2013

PR #19 gives about the same functionality as the first part of my PR, it's a matter of how you want to do it. I prefer the above as it allows the user to bypass the wrapper and make the Sort himself if what the utility function for creating sorts is not sufficient, e.g. creating a custom sort.

2 does pretty much the same, it gives the user the ability make his own query if what the queryparser provides is not enough, rather than preventing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant