Skip to content

Commit

Permalink
fix(lab): click to open file
Browse files Browse the repository at this point in the history
  • Loading branch information
xujingli committed Jan 24, 2024
1 parent daef1cd commit 2744da3
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 23 deletions.
2 changes: 1 addition & 1 deletion packages/libro-jupyter/src/file/file-view/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class FileView extends FileTreeView {
opener.open(treeNode.uri, {
viewOptions: {
name: treeNode.fileStat.name,
fileSize: treeNode.fileStat.size,
// fileSize: treeNode.fileStat.size,
},
});
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,44 +1,49 @@
import { CloseOutlined } from '@ant-design/icons';
import { renderNode, useInject, ViewContext, ViewInstance } from '@difizen/mana-app';
// import { OpenerService, URI } from '@difizen/mana-app';
import { OpenerService, URI } from '@difizen/mana-app';

import type { SaveableTabView } from '../../index.js';

export const OpenedTabs: React.FC = () => {
const tabs = useInject<SaveableTabView>(ViewInstance);
// const openService = useInject<OpenerService>(OpenerService);
const openService = useInject<OpenerService>(OpenerService);

const renderTitleIcon = renderNode;
const renderTitleLabel = renderNode;

return (
<>
{tabs.children.map((item) => {
// const path = item.filePath;
// const name = item.title.label;
return (
<ViewContext view={item} key={item.id}>
<div
title={item.title.caption}
className="libro-panel-collapse-item"
// onClick={() => {
// const uri = new URI(path);
// openService
// .getOpener(uri)
// .then((opener) => {
// if (opener) {
// opener.open(uri, {
// viewOptions: {
// name: name,
// },
// });
// }
// return;
// })
// .catch((e) => {
// console.error(e);
// });
// }}
onClick={() => {
if (!item.filePath) {
return;
}

const path = item.filePath;
const name = item.title.label;

const uri = new URI(path);
openService
.getOpener(uri)
.then((opener) => {
if (opener) {
opener.open(uri, {
viewOptions: {
name: name,
},
});
}
return;
})
.catch((e) => {
console.error(e);
});
}}
>
{item.title.icon && (
<span className="libro-panel-collapse-item-icon">
Expand Down

0 comments on commit 2744da3

Please sign in to comment.