-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Link card to profile #361
base: main
Are you sure you want to change the base?
Conversation
fix: section and button not in center on desktop
✅ Deploy Preview for wedance-panics7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
static/img/brand.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is changed now
pages/nfc/_landing.vue
Outdated
name="instagram" | ||
size="10" | ||
class="rounded-full p-2" | ||
style="box-shadow: 0px 1px 3px rgba(0, 0, 0, 0.1), 0px 1px 2px rgba(0, 0, 0, 0.06);" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tailwind shadows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to use "shadow" tailwind class
pages/nfc/_landing.vue
Outdated
const { softUpdate } = useDoc('nfc-card') | ||
let username = '' | ||
|
||
let pageId = $nuxt.$route.params.landing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
landing
is confusing name for param, rename it to id
let pageId = $nuxt.$route.params.landing | |
let pageId = $nuxt.$route.params.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is "id" now
pages/nfc/_landing.vue
Outdated
|
||
let pageId = $nuxt.$route.params.landing | ||
// when page is loaded after signIn | ||
if (pageId === undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shorter:
if (pageId === undefined) { | |
if (!pageId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix error "nuxt is not defined" I changed my implementation, so this code is outdated
pages/nfc/index.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that page is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page is removed now
components/TBenefits.vue
Outdated
default() { | ||
return [] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shorter:
default() { | |
return [] | |
}, | |
default: () => [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed code, so it is shorter now
components/TPremium.vue
Outdated
|
||
<TBenefits | ||
title="Why get Premium?" | ||
icon="check-green" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is already set by default, no need to overwrite it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I had changed code
components/TProfile.vue
Outdated
}, | ||
mounted() { | ||
// show tryPremium modal | ||
const query = $nuxt.$route.query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solution for: error '$nuxt' is not defined
const query = $nuxt.$route.query | |
const query = this.$route.query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had error in diferent file, so this does not fix anything, but I added this implementation
error '$nuxt' is not defined and warning unexpected usage of 'this'
This feature will allow user to link nfc card to his profile
How to test:
Closes #349